mirror of
https://github.com/GSA/notifications-api.git
synced 2025-12-21 07:51:13 -05:00
17ba8db97f
1. No longer create jobs when creating letters from api 🎉
2. Bulk update notifications based on the notification references after
we send them to DVLA - either as success or as error
46 lines
1.6 KiB
Python
46 lines
1.6 KiB
Python
from app import create_random_identifier
|
|
from app.models import LETTER_TYPE, JOB_STATUS_READY_TO_SEND, Job
|
|
from app.dao.jobs_dao import dao_create_job
|
|
from app.notifications.process_notifications import persist_notification
|
|
from app.v2.errors import InvalidRequest
|
|
from app.variables import LETTER_API_FILENAME
|
|
|
|
|
|
def create_letter_api_job(template):
|
|
service = template.service
|
|
if not service.active:
|
|
raise InvalidRequest('Service {} is inactive'.format(service.id), 403)
|
|
if template.archived:
|
|
raise InvalidRequest('Template {} is deleted'.format(template.id), 400)
|
|
|
|
job = Job(
|
|
original_file_name=LETTER_API_FILENAME,
|
|
service=service,
|
|
template=template,
|
|
template_version=template.version,
|
|
notification_count=1,
|
|
job_status=JOB_STATUS_READY_TO_SEND,
|
|
created_by=None
|
|
)
|
|
dao_create_job(job)
|
|
return job
|
|
|
|
|
|
def create_letter_notification(letter_data, template, api_key):
|
|
notification = persist_notification(
|
|
template_id=template.id,
|
|
template_version=template.version,
|
|
# we only accept addresses_with_underscores from the API (from CSV we also accept dashes, spaces etc)
|
|
recipient=letter_data['personalisation']['address_line_1'],
|
|
service=job.service,
|
|
personalisation=letter_data['personalisation'],
|
|
notification_type=LETTER_TYPE,
|
|
api_key_id=api_key.id,
|
|
key_type=api_key.key_type,
|
|
job_id=None,
|
|
job_row_number=None,
|
|
reference=create_random_identifier(),
|
|
client_reference=letter_data.get('reference')
|
|
)
|
|
return notification
|