Rebecca Law
46beece158
For the post_sms_response and post_email_response the reference property is always present but the value can be null.
...
Added a test for an empty reference.
Remove datetime format on the created_at attribute of a notification, it is not needed.
2016-11-21 17:32:36 +00:00
Rebecca Law
f5e3c6f63b
Remove print stmt and added assert error content
2016-11-17 14:02:44 +00:00
Rebecca Law
bc434f1736
Create new column in notifications and notification_history to store the client_reference because I remembered that reference is used for email providers.
2016-11-17 13:42:34 +00:00
Rebecca Law
dc5e21a78e
Remove v2 error handler for InvalidPhoneError, no longer expect to throw this exception.
2016-11-17 09:09:24 +00:00
Rebecca Law
df62be421f
Make email_from and subject required attributes of the email_content schema.
...
Update the format_checkers to raise the specific exception that why the validator can handle multiple messages.
Which led to a refactor of build_error_message.
2016-11-16 17:25:00 +00:00
Rebecca Law
68537d960a
Merge branch 'master' into implement-v2-send-email
2016-11-16 16:29:41 +00:00
Rebecca Law
247668202b
Fix functional tests
2016-11-16 16:15:30 +00:00
Rebecca Law
924cec05b4
Included reference when persisting the notification.
...
This was already part of the data model.
Not included in the send_sms|email task because there is no reference from the job.
2016-11-16 15:44:16 +00:00
Rebecca Law
a3eeb1a477
Merge branch 'master' into implement-v2-send-email
2016-11-16 15:18:03 +00:00
Rebecca Law
80f3bfcb2c
Merge pull request #733 from alphagov/refactor-for-code-reuse
...
Refactor for code reuse
2016-11-16 15:17:30 +00:00
Rebecca Law
d6c537cf44
Added job_id and row_number to the exception error message if the task needs to be retried. That way we have a way to tie the exception messages together
2016-11-15 11:44:48 +00:00
Leo Hemsted
61a166193c
Merge pull request #737 from alphagov/dont-deactivate-twice
...
archive service - don't re-delete templates etc
2016-11-14 17:04:52 +00:00
Rebecca Law
c00eb0f5a4
Remove from_request method on the Notification db model, was not needed anymore.
...
Use Notifications.query.one(), rather than assert count is 1 and query for all and get first item in list.
2016-11-14 14:41:32 +00:00
Leo Hemsted
d706d86c9c
don't re-delete already archived/revoked templates/api-keys
2016-11-14 14:10:40 +00:00
Rebecca Law
b0ee09a9f6
Implemented the post email notifications endpoint for v2
2016-11-14 13:56:09 +00:00
Rebecca Law
4379308189
Fix test failures.
2016-11-11 17:28:15 +00:00
Rebecca Law
8f0a96c76c
Merge branch 'master' into refactor-for-code-reuse
2016-11-11 16:51:18 +00:00
Chris Hill-Scott
705a0e7ab8
Remove redundant assignment
...
This variable is used exactly once, on the next line 🤔
2016-11-11 16:47:06 +00:00
Chris Hill-Scott
3e6d581f73
Use constants for template type
...
Handy if we ever want to rename these I guess…
2016-11-11 16:47:05 +00:00
Rebecca Law
4f5254134b
Fix logging in send_sms and send_email
2016-11-11 16:09:09 +00:00
Rebecca Law
4fe8d700ae
Fix the send_sms and send_email code to send the notification id that has been persisted.
2016-11-11 16:00:31 +00:00
Leo Hemsted
95764af6ea
Merge pull request #723 from alphagov/active-service
...
deactivate a service
2016-11-11 15:25:32 +00:00
Rebecca Law
c45d1f63a7
Use the same method to persist a notification.
...
Refactored the send_sms task to use this method.
2016-11-11 14:56:33 +00:00
Leo Hemsted
195f3615e6
add test that if we have an exception, nothing is committed
2016-11-11 14:40:25 +00:00
imdadahad
10f9dfde6e
Merge pull request #725 from alphagov/update-user-profile-endpoints
...
Refactor saving user profile
2016-11-11 11:24:31 +00:00
Leo Hemsted
9ae6e14140
move deactivate functionality into one database transactions
...
this means that any errors will cause the entire thing to roll back
unfortunately, to do this we have to circumvent our regular code, which calls commit a lot, and lazily loads a lot of things, which will flush, and cause the version decorators to fail. so we have to write a lot of stuff by hand and re-select the service (even though it's already been queried) just to populate the api_keys and templates relationship on it
2016-11-11 11:20:41 +00:00
Rebecca Law
2e4fab1b55
Merge pull request #732 from alphagov/change-v2-error-resp
...
Change v2 error resp
2016-11-11 11:07:59 +00:00
Rebecca Law
488ba7a1ef
Remove import
2016-11-11 10:56:21 +00:00
Rebecca Law
b0d88e0888
Removed OrderedDict
...
Added missing assert in test
2016-11-11 10:50:38 +00:00
Rebecca Law
eafbbd9809
Refactor send_sms and send_email to use common code to persist the notificaiton.
2016-11-11 10:41:39 +00:00
Chris Hill-Scott
d51c63cb6b
Merge pull request #722 from alphagov/whitepace-in-personalisation
...
Ignore case and whitespace in personalisation keys
2016-11-11 11:33:37 +01:00
Rebecca Law
c758694b98
Change validation error message to a string from a dict.
2016-11-10 16:30:51 +00:00
Rebecca Law
7d763260ce
Update format of the errors for DataError and exception
2016-11-10 14:53:39 +00:00
Rebecca Law
26d6a0c1a9
Merge branch 'master' into change-v2-error-resp
2016-11-10 14:21:20 +00:00
Leo Hemsted
17cf582502
Merge branch 'master' into active-service
2016-11-10 13:54:02 +00:00
Leo Hemsted
abecb5ff98
Merge pull request #726 from alphagov/auth-500
...
update python client to 2.0.0
2016-11-10 13:47:34 +00:00
Imdad Ahad
f85ee54707
Refactor stuff + stricter validation for updating only ALLOWED user attrs
2016-11-10 13:09:25 +00:00
Imdad Ahad
8b64aa7e79
Use POST endpoint for updating a user attr
2016-11-10 12:07:29 +00:00
Chris Hill-Scott
8474344c9a
Ignore case and whitespace in personalisation keys
...
From a support ticket:
> it's possible to add a personalisation token with trailing whitespace
> (eg. "key " rather than "key"). Can this be trimmed in the UI to guard
> against this? (one of our devs copied and pasted it from a document
> and inadvertently included the space)
> Nothing major but caused a few hours of investigations!
Rather than trim the placeholder in the template, we should treat
placeholders in API calls the same way we do with CSV files, ie we
ignore case and spacing in the name of the placeholder. So
`(( First Name))` is equivalent to `((first_name))`, and both would be
populated with a dictionary like `{'firstName': 'Chris'}`.
Depends on:
- [x] https://github.com/alphagov/notifications-utils/pull/77
2016-11-10 11:40:00 +00:00
Leo Hemsted
e8c3a5cdde
add check for inactive services to auth handler
...
cleaned up some auth code to marginally improve efficiency of error checking
and hopefully make it easier to read
fixed some incorrect auth headers in the deactivate tests
2016-11-10 11:07:12 +00:00
Leo Hemsted
b2149bf02a
undo unnecessary change to models
2016-11-10 10:38:36 +00:00
Leo Hemsted
b0e240267a
add only_active flag to get services functionality
2016-11-09 15:07:23 +00:00
Rebecca Law
346d90e319
update V2 error response to
...
{status_code: 403,
errors: [error: AuthError, message: token has expired}]
}
2016-11-09 14:56:54 +00:00
Imdad Ahad
31dfc36094
Merge branch 'master' into update-user-profile-endpoints
2016-11-09 12:41:21 +00:00
Leo Hemsted
d4a300ec7a
add only_active flag to GET /services/
...
does what it says on the tin
2016-11-09 11:45:39 +00:00
Leo Hemsted
efd2be9acb
set service to active on creation
2016-11-08 17:10:28 +00:00
Leo Hemsted
089ac099f3
POST /service/{id}/deactivate deactivates a service:
...
* set active=False on the service
* renames service to "_archived_{old_name}"
* archives all templates for the service
* revokes all api keys for the service
2016-11-08 17:10:28 +00:00
Leo Hemsted
da2fa5b4bc
move sqlalchemy defaults from booleans to SQL constructs
...
booleans aren't actually allowed, and quietly do nothing
also default Services.active to true
2016-11-08 17:10:28 +00:00
Rebecca Law
78e84801bd
Merge branch 'master' into change-v2-error-resp
2016-11-08 15:59:42 +00:00
Imdad Ahad
3f10e59db3
Add user dao method to update a single user attr
2016-11-07 17:42:39 +00:00
