darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-31 23:26:23 -05:00
Code Issues Packages Projects Releases Wiki Activity

For the post_sms_response and post_email_response the reference property is always present but the value can be null.

Browse Source 
Added a test for an empty reference.
Remove datetime format on the created_at attribute of a notification, it is not needed.
This commit is contained in:
Rebecca Law
2016-11-21 17:32:36 +00:00
parent 1345c94f4b
commit 46beece158
4 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/notifications/process_notifications.py
View File

@@ -57,7 +57,7 @@ def persist_notification(template_id,
notification_type=notification_type,
api_key_id=api_key_id,
key_type=key_type,
created_at=created_at or datetime.utcnow().strftime(DATETIME_FORMAT),
created_at=created_at or datetime.utcnow(),
job_id=job_id,
job_row_number=job_row_number,
client_reference=reference

4
app/v2/notifications/notification_schemas.py
View File

@@ -47,7 +47,7 @@ post_sms_response = {
"title": "response v2/notifications/sms",
"properties": {
"id": uuid,
"reference": {"type": "string"},
"reference": {"type": ["string", "null"]},
"content": sms_content,
"uri": {"type": "string"},
"template": template
@@ -90,7 +90,7 @@ post_email_response = {
"title": "response v2/notifications/email",
"properties": {
"id": uuid,
"reference": {"type": "string"},
"reference": {"type": ["string", "null"]},
"content": email_content,
"uri": {"type": "string"},
"template": template

4
app/v2/notifications/post_notifications.py
View File

@@ -38,7 +38,7 @@ def post_sms_notification():
notification_type=SMS_TYPE,
api_key_id=api_user.id,
key_type=api_user.key_type,
reference=form['reference'])
reference=form.get('reference'))
send_notification_to_queue(notification, service.research_mode)
resp = create_post_sms_response_from_notification(notification,
@@ -65,7 +65,7 @@ def post_email_notification():
notification_type=EMAIL_TYPE,
api_key_id=api_user.id,
key_type=api_user.key_type,
reference=form['reference'])
reference=form.get('reference'))
send_notification_to_queue(notification, service.research_mode)