Leo Hemsted
ea0ba8d87a
Revert "Remove nulls from sms_sender"
2017-05-31 14:52:48 +01:00
Leo Hemsted
6c5affbebc
Merge pull request #988 from alphagov/non-null-again
...
Remove nulls from sms_sender
2017-05-31 14:27:49 +01:00
Chris Hill-Scott
8952dc2ced
Merge pull request #997 from alphagov/dont-validate-recipient-search
...
Don’t 500 when searching with bad email address
2017-05-31 12:39:37 +01:00
Imdad Ahad
1c90c8be16
Merge pull request #993 from alphagov/imdad-poc-add-diff-migration-script
...
POC: Add a script to check if there are new migrations
2017-05-31 10:52:59 +01:00
Chris Hill-Scott
9ada8b2753
Don’t 500 when searching with bad email address
...
In the future we might want to validate email addresses before
attempting to search by them. But for a first pass we can just return
no results when a user types in something that isn’t an email address
or phone number.
It definitely better than returning a 500.
2017-05-30 14:50:48 +01:00
Leo Hemsted
de3b5a13a9
version number bump
2017-05-30 12:49:30 +01:00
Leo Hemsted
db4b3e371a
remove null sms sender test
...
it's no longer possible for an sms_sender to be null
2017-05-30 10:47:52 +01:00
Leo Hemsted
012b2bf36c
version number bump
2017-05-30 10:47:15 +01:00
Leo Hemsted
25011f09ef
test no longer applicable as null sms_sender is an error now
2017-05-30 10:47:15 +01:00
Leo Hemsted
eb6edf06a3
add upgrade script to remove non-null values from the sender column
2017-05-30 10:47:15 +01:00
Leo Hemsted
58503c855a
set sms_sender to be 'GOVUK' if not otherwise specified
...
this is a precursor to making the column non-nullable
2017-05-30 10:47:15 +01:00
minglis
f7e1ccea8b
Merge pull request #987 from alphagov/redo-queue-visibitlity-timeout
...
Redo queue visibitlity timeout
2017-05-30 10:36:53 +01:00
Martyn Inglis
75c5e5e5d5
Merge branch 'master' into redo-queue-visibitlity-timeout
...
Conflicts:
app/notifications/process_notifications.py
app/v2/notifications/post_notifications.py
2017-05-30 10:18:18 +01:00
kentsanggds
c59746a4a7
Merge pull request #992 from alphagov/ken-refactor-service-schema
...
Refactor schema to remove redundant bits
2017-05-26 17:40:09 +01:00
Ken Tsang
112c673593
Removed a few lines from schema
2017-05-26 17:23:01 +01:00
Ken Tsang
18b8382d6e
Refactor schema and improve tests
2017-05-26 17:17:15 +01:00
Imdad Ahad
a58e724d21
Add a script and make command to detect if there are any migration changes
2017-05-26 16:44:23 +01:00
Ken Tsang
56e9faab2e
Refactor schema
2017-05-26 16:21:22 +01:00
kentsanggds
263adac805
Merge pull request #984 from alphagov/ken-update-api-service-permissions-handling
...
Ken update api service permissions handling
2017-05-26 14:39:27 +01:00
Imdad Ahad
6b27091edf
Merge pull request #985 from alphagov/imdad-feat-search-normalised-notifications
...
Search notifications against normalised address
2017-05-26 12:39:18 +01:00
Ken Tsang
7aca3d8f43
Remove flags process in service_dao.create_service
2017-05-26 12:04:16 +01:00
Imdad Ahad
77b82305f4
Search normalised in get_notifications_for_service:
...
* Use dao method to search against normalised(recipient)
* Add filter to accept one or more statuses
2017-05-26 11:58:50 +01:00
Imdad Ahad
78c10b7d30
Search notification against normalised recipient with filter for status
2017-05-26 11:45:56 +01:00
Imdad Ahad
cfe08a4d8b
Store the normalised number on the notification
2017-05-26 11:36:24 +01:00
Imdad Ahad
44badf38cc
Merge pull request #981 from alphagov/imdad-feat-persist-normalised-recipient
...
Persist normalised recipient to `Notification`
2017-05-26 10:40:11 +01:00
Imdad Ahad
6c4377bd44
Persist normalised email
2017-05-26 10:26:07 +01:00
Imdad Ahad
cbc92a6173
Store the normalised number on the notification
2017-05-26 10:26:07 +01:00
Ken Tsang
1375bbe400
Refactor schema to improve error response
2017-05-25 17:55:24 +01:00
Ken Tsang
54d85fd8df
Add tests for services with no permissions
2017-05-25 17:48:09 +01:00
Ken Tsang
8488895612
Refactored tests
2017-05-25 17:48:09 +01:00
Ken Tsang
f7a18f77cf
Update model to cascade permissions assoc proxy
2017-05-25 17:48:09 +01:00
Ken Tsang
234312ece0
Update service permissions to ensure state in sync
2017-05-25 17:48:09 +01:00
Ken Tsang
2f626fa6fc
Add permissions validation in service schema
2017-05-25 17:47:21 +01:00
Ken Tsang
e59a1ab104
Update tests for existing flags to set service permissions
2017-05-25 17:47:21 +01:00
Ken Tsang
8e3e31faaf
Updated service DAO and API end points
2017-05-25 17:47:21 +01:00
Rebecca Law
389515ce02
Merge pull request #990 from alphagov/schedule-api-notification
...
Add iso8601 to requirements
2017-05-25 16:26:53 +01:00
Rebecca Law
1f591d3490
Add iso8601 to requirements
2017-05-25 16:13:33 +01:00
Rebecca Law
80119e2c84
Merge pull request #975 from alphagov/schedule-api-notification
...
Schedule api notification
2017-05-25 15:51:56 +01:00
minglis
0b82516951
Merge pull request #989 from alphagov/imdad-feat-add-sqs-queue-delete-script
...
Add script to delete SQS queues
2017-05-25 15:12:37 +01:00
Rebecca Law
6ad36b274b
Fix merge conflict with migration file
2017-05-25 13:46:03 +01:00
Martyn Inglis
29b6a918e8
Ensure dev and test builds will read from old and new queues
2017-05-25 13:43:31 +01:00
Rebecca Law
b745e13a28
Merge branch 'master' into schedule-api-notification
2017-05-25 13:37:04 +01:00
Imdad Ahad
586c83a2c7
Add a script to delete sqs queues:
...
* Uses boto to retrieve/delete queues
* Additional functions to output/read from csv
2017-05-25 13:33:26 +01:00
Leo Hemsted
d23a92fbc0
Merge pull request #952 from alphagov/international-delivery-receipts
...
update delivery receipts for countries that return them
2017-05-25 13:13:49 +01:00
Rebecca Law
f555c7a73b
Refactor tests to use the create_notication in tests.app.db
2017-05-25 11:41:07 +01:00
Martyn Inglis
58af4e5ee9
timeout slightly longer than retry
2017-05-25 11:20:23 +01:00
Martyn Inglis
753d58f138
Adds new queues to the PaaS workers
2017-05-25 11:15:28 +01:00
Martyn Inglis
4768f0b9fd
Change retries policy.
...
Before we had a long back off, now we have more, but shorter backoffs.
- PREVIOUS
When we had an error talking to a provider we retried quickly and if we still got errors we backed off more and more. Maximum attempts was 5, max delay 4hours. This was to allow us time to ship a build if that was required.
- NOW
Backing off 48 times of 5 minutes each. This gives us the same total backoff, but many more tries in that period.
- WHY
Having the long back off meant messages could be delayed 4 hours. This was happening more and more, as PaaS deploys can place things into the "inflight" state in SQS. The inflight state MUST have an expiry time LONGER than the maximum retry back off. This meant that messages would be delayed 4 hours, even when there was no app error.
By doing this we can reduce this delay to 5 minutes. Whilst still giving us time to fix issues.
2017-05-25 11:12:40 +01:00
Leo Hemsted
57b7cb8d24
Merge pull request #986 from alphagov/create-service-bug
...
separate service deserialization from validation
2017-05-25 10:52:38 +01:00
Martyn Inglis
2591d3a1df
This massive set of changes uses the new queue names object throughout the app and tests.
...
Lots of changes, all changing the line of code that puts things into queues, and the code that tests that.
2017-05-25 10:51:49 +01:00
