Commit Graph

5071 Commits

Author SHA1 Message Date
Rebecca Law
e32debbca1 Add more tests 2018-04-25 15:40:44 +01:00
Rebecca Law
d00614205e Adding test for fetch_biling_data_for_day. 2018-04-25 14:45:51 +01:00
Rebecca Law
16ef133aa5 Refactor reporting task so that methods can be used for the annual usage page.
Still a work in progress, tests are coming.
2018-04-25 14:45:51 +01:00
Rebecca Law
bd91aac763 Write some pseudo code for ft billing 2018-04-25 14:45:51 +01:00
Rebecca Law
8cd4e1be29 Query ft_billing aggregate for a month 2018-04-25 14:45:51 +01:00
Rebecca Law
731f29f2f7 Merge pull request #1842 from alphagov/fix-letter-in-sending-alert
Fix alert for letters still in sending
2018-04-25 14:44:44 +01:00
Rebecca Law
cb2a910469 Update variable name 2018-04-25 14:29:39 +01:00
Rebecca Law
b1ecf88283 Merge pull request #1841 from alphagov/pyup-update-pytest-3.5.0-to-3.5.1
Update pytest to 3.5.1
2018-04-25 11:01:21 +01:00
Rebecca Law
6e1417481c Remove print stmt 2018-04-25 10:16:01 +01:00
Rebecca Law
167f7a18e3 Fix the query that raises the alert for letters still in sending.
If Monday or Tuesday check for letters still sending after 4 days.
If Saturday or Sunday do nothing
If Wed, Thurs, Fri check for letters still sending after 2 days

Added test for Tuesday, corrected tests after the correction to query.
2018-04-25 10:10:25 +01:00
pyup-bot
95c39f6508 Update pytest from 3.5.0 to 3.5.1 2018-04-25 00:02:47 +01:00
Rebecca Law
0ceed13bee Merge pull request #1837 from alphagov/rebuild-monthly-billing
Update populate_monthly_billing to take a service_id and month
2018-04-23 16:42:42 +01:00
Rebecca Law
a91b46dfa9 Added the else so the entire table does not rebuild. 2018-04-23 16:16:41 +01:00
Chris Hill-Scott
258ee6c498 Merge pull request #1835 from alphagov/pyup-update-moto-1.3.1-to-1.3.3
Update moto to 1.3.3
2018-04-23 15:48:22 +01:00
Rebecca Law
12796051f5 We need to rebuild the monthly billing for one service for the month of March.
This change makes that possible without affecting any other data in the table.
2018-04-23 13:53:47 +01:00
Katie Smith
fb6c07573f Merge pull request #1834 from alphagov/migration-to-add-active-column-to-replyto-tables
Add is_active column for the 3 reply_to tables
2018-04-23 12:34:05 +01:00
pyup-bot
08fbd04eb7 Update moto from 1.3.1 to 1.3.3 2018-04-19 00:11:32 +01:00
Katie Smith
c401314072 Add is_active column for the 3 reply_to tables
Added a new boolean column, `is_active` to these tables
* service_email_reply_to
* service_sms_senders
* service_letter_contacts

This has a database default of True in order to backfill the data, but
this default will be replaced with a model default later.
2018-04-17 16:23:46 +01:00
Chris Hill-Scott
e75c84a88c Merge pull request #1831 from alphagov/normalise-newlines-sms
Bump utils to normalise newlines in text messages
2018-04-12 15:05:08 +01:00
Chris Hill-Scott
308511e0ed Bump utils to normalise newlines in text messages
Brings in:
- [ ] https://github.com/alphagov/notifications-utils/pull/460
2018-04-12 11:13:02 +01:00
Sakis
a025e2cc9c Merge pull request #1811 from alphagov/add-http-healthchecks
Add http health-check for the api app
2018-04-11 15:51:05 +01:00
Athanasios Voutsadakis
0766e68099 Revert "Add 5 second sleep before stopping old api instances"
This reverts commit 23cfe73c48.
2018-04-11 15:38:41 +01:00
Athanasios Voutsadakis
23cfe73c48 Add 5 second sleep before stopping old api instances
This is to allow the new instances to start responding to the http
healthchecks and start serving traffic.
2018-04-11 15:01:45 +01:00
Athanasios Voutsadakis
e2a05efae0 Merge branch 'master' into add-http-healthchecks 2018-04-11 13:45:20 +01:00
Chris Hill-Scott
87ac1f15b7 Merge pull request #1829 from alphagov/bump-utils-plain-text-email-formatting
Bump utils to improve plain text email formatting
2018-04-10 11:37:40 +01:00
Chris Hill-Scott
c9882e2f9c Bump utils to improve plain text email formatting
Brings in:
- [x] https://github.com/alphagov/notifications-utils/pull/438
- [x] https://github.com/alphagov/notifications-utils/pull/450
- [x] https://github.com/alphagov/notifications-utils/pull/454

Changes:
- https://github.com/alphagov/notifications-utils/compare/25.3.0...26.2.0
2018-04-10 11:14:48 +01:00
Alexey Bezhan
84b99a9796 Merge pull request #1823 from alphagov/post-notification-with-document-upload
Post notification with document upload
2018-04-10 10:33:34 +01:00
Katie Smith
abade902e1 Merge pull request #1827 from alphagov/change-letter-still-sending-notification-date
Add extra day before raising letter still sending alert
2018-04-10 09:36:30 +01:00
Katie Smith
5ab46c737d Merge pull request #1830 from alphagov/pyup-update-pytest-mock-1.8.0-to-1.9.0
Update pytest-mock to 1.9.0
2018-04-10 09:36:22 +01:00
Katie Smith
417d382d1b Add extra day before raising letter still sending alert
We now want to wait an extra day before sending the alert that letters
are still sending.
2018-04-10 09:29:29 +01:00
pyup-bot
1e1e6c3550 Update pytest-mock from 1.8.0 to 1.9.0 2018-04-10 04:28:17 +01:00
Alexey Bezhan
89f2f8b9a7 Test that document download requests set the auth header 2018-04-09 16:30:16 +01:00
Alexey Bezhan
c189f09687 Update template content values from notification personalisation
We need to set template_with_content placeholder values with an
updated personalisation dictionary after processing the document
uploads in order to avoid returning base64 file data instead of
the document URLs in the response contents.
2018-04-09 16:30:16 +01:00
Alexey Bezhan
b097a16a86 Handle and log document-download-api request errors
Catches the requests exception for document-download-api calls, logs
a warning and returns a matching response code and message.

Connection errors to document download result in 503 response to the
user.
2018-04-09 16:30:16 +01:00
Alexey Bezhan
f2e163dc43 Upload files from personalisation data to document download
Adds support for a new personalisation value type: file upload.

File uploads are represented as a dictionary with a "file" key and
a base64-encoded file data as the key's value:

```
personalisation={
  'field1': {'file': '<base64-encoded file contents>'}
}
```

Post notification endpoint checks the request personalisation data
looking for the file uploads in personalisation data. If any are
found and the service has permissions to upload documents the files
are sent to document download API and personalisation values are
replaced with the URLs returned in the document download response.

A fake document URL is returned for simulated notifications, no
documents are stored in Document Download.

Multiple files can be uploaded for one notification by providing
a file upload in more than one personalisation field.
2018-04-09 16:30:16 +01:00
Alexey Bezhan
204aaf172d Add a document download client
Allows uploading documents to the Document Download API.
The client is configured with an API host and auth token. There's
no need for a flag to disable the client in the test environments
at the moment since the upload is only triggered by a specific
payload which would only be sent with an explicit goal of using
document download.
2018-04-09 16:30:16 +01:00
Rebecca Law
a0c6f6a22e Merge pull request #1828 from alphagov/refactor-post-letters
refactor post letters
2018-04-09 16:13:54 +01:00
Leo Hemsted
46021f4604 Merge pull request #1826 from alphagov/pyup-update-pytest-mock-1.7.1-to-1.8.0
Update pytest-mock to 1.8.0
2018-04-09 15:17:23 +01:00
Leo Hemsted
aa7a33c859 Merge pull request #1815 from alphagov/pyup-update-sqlalchemy-1.2.5-to-1.2.6
Update sqlalchemy to 1.2.6
2018-04-09 15:17:14 +01:00
Leo Hemsted
41e3a150d8 Merge pull request #1824 from alphagov/redis-populate-command-fix
make sure redis command filters dates properly
2018-04-09 15:17:07 +01:00
Rebecca Law
b73bf4220f Refactor process_letter_notification to make the code easier to read.
- Separated the logic of precompiled and template letters.
- Remove the check for research mode, research mode is not relevant to api calls. The test key is used for testing.
Refactor upload_pdf_letter to accept a precompile boolean to save a query to template.
2018-04-09 13:56:44 +01:00
Leo Hemsted
ac0b2d79a2 sys.exit rather than throwing an assertion error
Assertions should only be used in tests - they can be disabled at
runtime by setting the python flag -O (though I don't believe we use
that flag under normal circumstances).

also clean up test asserts - mock_redis is the redis object, so its
`called` property will always be false, because we never say
`redis_store()`. Rather, we should use the `mock_calls` property to
see all calls to all of its children
2018-04-09 11:45:43 +01:00
pyup-bot
a6b3c3e018 Update pytest-mock from 1.7.1 to 1.8.0 2018-04-07 05:13:11 +01:00
Rebecca Law
e7bd6380ab Merge pull request #1825 from alphagov/revert-1820-ken-fix-precompiled-research-mode
Revert "Fix research mode preview of precompiled letters"
2018-04-06 16:14:46 +01:00
Rebecca Law
3c92f00fdb Revert "Fix research mode preview of precompiled letters" 2018-04-06 16:10:06 +01:00
Rebecca Law
002b96b4f8 Merge pull request #1820 from alphagov/ken-fix-precompiled-research-mode
Fix research mode preview of precompiled letters
2018-04-06 15:22:09 +01:00
Rebecca Law
39e4f63b8c Use the positive condition when checking the environment 2018-04-06 12:01:16 +01:00
Chris Waszczuk
15d92e235f Merge pull request #1822 from alphagov/added-new-paginated-inbound-endpoint
Added new paginated inbound endpoint
2018-04-06 11:11:48 +01:00
Leo Hemsted
ba612b0f5b make sure redis command filters dates properly
also write the tests that i should have written a while ago for this
2018-04-05 15:11:29 +01:00
chrisw
0f2ddd8cfa added new paginated inbound endpoint 2018-04-04 17:10:41 +01:00