Commit Graph

4699 Commits

Author SHA1 Message Date
Alexey Bezhan
dc99fe5ff3 Set Templates.hidden column as non-nullable
Sets hidden to false for all existing templates and makes column
non-nullable.
2018-02-26 13:28:08 +00:00
Alexey Bezhan
6ad868d22e Merge pull request #1707 from alphagov/dont-hide-hidden-templates-just-yet
Revert "Don't return hidden templates in API service template responses"
2018-02-26 11:54:01 +00:00
Alexey Bezhan
9b3a9a55c4 Revert "Don't return hidden templates in API service template responses"
Filtering out hidden templates requires all existing templates to
have `hidden` flag set, which can only be done by a migration after
the code that sets the flag to `False` by default for new templates
has been released.

This removes the filtering logic until the migration has been released.
2018-02-26 11:44:25 +00:00
Alexey Bezhan
b44f08bd0f Merge pull request #1706 from alphagov/nullable-template-hidden
Set Template.hidden as nullable before the new app code gets released
2018-02-26 10:56:06 +00:00
Alexey Bezhan
3a15a7e783 Set Template.hidden as nullable before the new app code gets released
Since the application code gets released after the migration setting
a new Template field as non-nullable prevents new templates from being
created by the existing application instances.

This splits the migration to set fields as nullable first and then
update existing records once the application code has been released.

0168 is modified not to run UPDATE query or set non-nullable flag in
staging and production. 0169 is added to rollback preview.
2018-02-26 10:46:20 +00:00
Alexey Bezhan
22382718e0 Merge pull request #1703 from alphagov/pre-compiled-letter-pdf-endpoint
Post pre-compiled letter PDF notification endpoint
2018-02-26 10:22:03 +00:00
Alexey Bezhan
19dbe7da8d Don't return hidden templates in API service template responses
Removes hidden templates from the service templates list and returns
404 when searching for a hidden template or template versions by ID.
2018-02-23 17:52:25 +00:00
Alexey Bezhan
d803b48d23 Return 400 response for invalid per-compiled letter content 2018-02-23 17:52:25 +00:00
Alexey Bezhan
bef91bcd99 Check for precompiled letter permission in the post notification 2018-02-23 17:52:25 +00:00
Alexey Bezhan
8971a5adce Upload pre-compiled letter PDF to S3
Pre-compiled letter endpoint uploads PDF contents to S3 directly
instead of creating a letter task to generate PDF using template
preview.

This moves some of the utility functions used by existing letter
celery tasks to app.letters.utils, so that they can be reused by
the API endpoint.
2018-02-23 17:52:25 +00:00
Alexey Bezhan
5327298371 Add a view function for pre-compiled PDF letters
Adds a separate view function that is registered under the same
route as existing letter POST notification.
2018-02-23 17:52:24 +00:00
Alexey Bezhan
e659253b01 Set Notify service user as the creator of Pre-compiled PDF template 2018-02-23 17:52:24 +00:00
Alexey Bezhan
6d1439e39a Add a DB migration to create Templates.hidden column
Creates the column as nullable, sets the value to false for all
existing templates and template versions and then applies a
not-nullable constraint.

All future Templates are created with `False` as the default set
in SQLAlchemy.
2018-02-23 17:52:24 +00:00
Alexey Bezhan
c4fddab6a6 Add a hidden column to templates
Allows hiding templates from the templates list in the admin app
and related API responses.

This is used for 'internal' templates that we create for notifications
that wouldn't have a template otherwise (eg pre-compiled PDF letters)
2018-02-23 13:38:15 +00:00
Rebecca Law
444dba994d Merge pull request #1698 from alphagov/add-exception-for-failed-letters
Added a new exception type for DVLAException
2018-02-23 10:42:10 +00:00
Leo Hemsted
c52ca3e7bb Merge pull request #1681 from alphagov/fix-test-db
make sure tests always run in test db
2018-02-22 16:54:57 +00:00
Rebecca Law
385653af44 Added a new exception type for DVLAException.
The Notify team needs to investigate when a notification is marked as failed.
We will process the whole file and mark the notifications with the appropriate status, if any are failed an exception is raised.
The exception will trigger a cloud watch error for the team to investigate.
2018-02-22 15:05:37 +00:00
Leo Hemsted
25d6b45ea2 Merge pull request #1692 from alphagov/service-name-change
don't return or accept sms_sender in update service anymore
2018-02-22 14:37:47 +00:00
Sakis
18a85a080d Merge pull request #1693 from alphagov/increase-pool-size
Increase DB connection pool size to 10
2018-02-22 11:33:53 +00:00
Leo Hemsted
aedbd37d8b don't return or accept reply_to_email in update service anymore
either
2018-02-22 11:03:35 +00:00
kentsanggds
c01aef2c48 Merge pull request #1694 from alphagov/ken-add-precompiled-letter-permission
Add precompiled_letter service permission
2018-02-22 10:27:52 +00:00
Athanasios Voutsadakis
c61ed043b3 Ensure pool size is an integer 2018-02-22 10:27:02 +00:00
Leo Hemsted
ee1be970fc make test config inherit from dev config
gets some secret keys and things set up for free
2018-02-21 18:42:24 +00:00
Leo Hemsted
073c48a0a7 move all static env vars from env.sh to config file in dev
There's no reason to have things that never change in environment.sh.
you'll want to update your environment.sh, then restart your shells
(`exec bash` or `exec zsh` etc)

This also changes the database to be set statically in the config, but
overridable from the command line if you need to - for example, jenkins
will override it with the dockerised postgres uri.
2018-02-21 18:12:03 +00:00
Ken Tsang
90e9d99161 Add precompiled_letter service permission
- migration script to add precompiled_letter in service_permission_types table and in service permission types list in models.py
2018-02-21 16:26:49 +00:00
Leo Hemsted
01ed4e1e56 Merge pull request #1679 from alphagov/pyup-update-eventlet-0.22.0-to-0.22.1
Update eventlet to 0.22.1
2018-02-21 16:26:27 +00:00
Leo Hemsted
a5827f9397 Merge pull request #1682 from alphagov/pyup-update-pytest-xdist-1.22.0-to-1.22.1
Update pytest-xdist to 1.22.1
2018-02-21 16:26:10 +00:00
Leo Hemsted
038f37984e Merge pull request #1689 from alphagov/pyup-update-pytest-3.4.0-to-3.4.1
Update pytest to 3.4.1
2018-02-21 16:25:58 +00:00
Leo Hemsted
c173b4b775 Merge pull request #1691 from alphagov/letter-pdf
send letters for services without letters_for_pdf
2018-02-21 16:25:33 +00:00
Leo Hemsted
34e98bc14c send letters for services without letters_for_pdf
also make sure that the service isn't in research mode
2018-02-21 15:59:52 +00:00
Athanasios Voutsadakis
dc19e644a6 Increase DB connection pool size to 10
This is to address some errors we saw yesterday such as:

`sqlalchemy.exc.TimeoutError: QueuePool limit of size 5 overflow 10
reached, connection timed out, timeout 30`

Related flask-sqlalchemy docs:
http://flask-sqlalchemy.pocoo.org/2.3/config/#configuration-keys
2018-02-21 15:47:58 +00:00
Leo Hemsted
703cee66f0 don't return or accept sms_sender in update service anymore
it's no longer a field on the service
2018-02-21 15:45:19 +00:00
Rebecca Law
f248234cfc Merge pull request #1690 from alphagov/command-to-add-inbound-numbers
Added a command to insert inbound numbers from file.
2018-02-21 14:09:17 +00:00
Rebecca Law
28925da575 Fix codestyle 2018-02-21 11:52:52 +00:00
Rebecca Law
9207325501 Added a message about the file format. 2018-02-21 10:30:34 +00:00
Rebecca Law
953a545aea Added a command to insert inbound numbers from file.
Expected file format is one number per line, each phone number should be 07... not 447..
2018-02-21 10:00:17 +00:00
pyup-bot
45af9c14cc Update pytest from 3.4.0 to 3.4.1 2018-02-20 22:10:50 +00:00
pyup-bot
d9032f8562 Update pytest-xdist from 1.22.0 to 1.22.1 2018-02-19 22:29:29 +00:00
Rebecca Law
e750636a57 Merge pull request #1665 from alphagov/reduce-log-level
Reduce logging level
2018-02-19 14:50:30 +00:00
Rebecca Law
927f6e8335 Catch itegrity errors and return 400.
When creating or updating an organisation an itegrity error is raise if the name is already used.
This change adds a new error handler for the organisation to catch the named unique index and return a 400 with a sensible message.
We have an other error handler for unique service names which was caught in the error handler for all blueprints. A new error handler for the service_blueprint has been created for catch those specific unique constraints.
This is a nice way to encapulate the specific errors for a specific blueprint.
2018-02-19 14:33:44 +00:00
Rebecca Law
d6a1e694e2 Merge branch 'master' into reduce-log-level 2018-02-19 11:21:06 +00:00
Chris Hill-Scott
a16a14aba5 Merge pull request #1675 from alphagov/pyup-update-pytest-mock-1.6.3-to-1.7.0
Update pytest-mock to 1.7.0
2018-02-19 10:38:43 +00:00
pyup-bot
7638df74a9 Update eventlet from 0.22.0 to 0.22.1 2018-02-17 18:25:26 +00:00
pyup-bot
87788d7a84 Update pytest-mock from 1.6.3 to 1.7.0 2018-02-16 21:24:23 +00:00
Leo Hemsted
3556851df9 Merge pull request #1672 from alphagov/org-users
Org user DB models
2018-02-16 10:57:27 +00:00
Katie Smith
be8b10a2dd Merge pull request #1666 from alphagov/remove-unnecessary-code
Remove unnecessary code to do with testing service name uniqueness
2018-02-15 16:42:43 +00:00
Katie Smith
a6dae2c81b Remove unnecessary code to do with testing service name uniqueness
notifications-admin has now been changed to always pass the service_id
to the 'service/unique' endpoint. This means we don't need to cover the
case of there being no service_id and the tests can also be updated.
2018-02-15 16:32:09 +00:00
Rebecca Law
c94cbb02b1 Merge pull request #1671 from alphagov/fix-uuid-validation
Fix UUID validate in the JSON schema
2018-02-15 14:23:02 +00:00
Leo Hemsted
83b26f4a93 use psycopg2-binary to supress warnings 2018-02-15 14:20:25 +00:00
Leo Hemsted
450deae32a add user_to_organisation and invited_organisation_users tables
similar to user_to_service and invited_users, but without auth types
or permissions
2018-02-15 14:19:24 +00:00