Commit Graph

974 Commits

Author SHA1 Message Date
Adam Shimali
da45a997f3 Merge pull request #410 from alphagov/better-error-logging
Better error logging
2016-06-13 15:05:17 +01:00
Adam Shimali
3d55c47d1e Rest methods that explicitly return errors by pass the error handlers as
they do not raise exceptions.

Introduced a simple exception that contains error messages and status
code that can be used rather than return json + status code from rest
methods directly.

The handler in errors for this exception can then log the error before
returning json.
2016-06-13 13:50:35 +01:00
Rebecca Law
b677768de1 Merge pull request #400 from alphagov/remove-task-send-sms-code
Remove task send_sms_code.
2016-06-13 11:34:26 +01:00
Leo Hemsted
59497fde17 Merge pull request #405 from alphagov/dashboard-slowdown
exclude notifications from job
2016-06-10 16:45:05 +01:00
Leo Hemsted
edc72a57ca add test file for schemas 2016-06-10 16:34:20 +01:00
Leo Hemsted
7083be429a exclude notifications from job
was being lazily loaded to get notification ids, so every time a job is loaded it would potentially select thousands of notifications from the database
2016-06-10 15:37:05 +01:00
Leo Hemsted
d0d2d0dbc8 Merge pull request #402 from alphagov/firetext-research-400s
fix firetext research mode requests
2016-06-09 15:25:00 +01:00
Leo Hemsted
fd2a0a0b10 fix firetext research mode requests
requests converts dicts into query parameters anyway if you don't specify so dont try and encode the data ourselves, also hardened up tests
2016-06-09 15:15:44 +01:00
Leo Hemsted
c14cb5c291 Merge pull request #399 from alphagov/order-template-api
fix template api tests being inconsistent by adding ordering
2016-06-09 11:59:33 +01:00
Rebecca Law
50ec2eb7fc Remove task send_sms_code.
We use a notify service to send the sms code via using a template.
2016-06-09 11:54:34 +01:00
Leo Hemsted
3e72440f38 fix template api tests being inconsistent by adding ordering 2016-06-09 11:24:04 +01:00
Leo Hemsted
511e65b9f9 Merge pull request #398 from alphagov/firetext-log
log firetext extended error codes
2016-06-09 10:46:01 +01:00
NIcholas Staples
964fd5ac35 Merge pull request #377 from alphagov/single_from_number
Replaced mmg from number and firetext from number with single from nu…
2016-06-09 10:41:39 +01:00
Leo Hemsted
6926769f66 log firetext response code 2016-06-09 10:35:07 +01:00
NIcholas Staples
9e73675f67 Merge pull request #396 from alphagov/set_provider_rates
Added migration to add rate. Tested worked locally.
2016-06-08 16:18:06 +01:00
NIcholas Staples
e783010e59 Merge pull request #397 from alphagov/timeout_sending_msgs
Task added to update 'sending' notifications after 72 hours, set task…
2016-06-08 16:16:59 +01:00
Nicholas Staples
8a1f4de217 Task added to update 'sending' notifications after 72 hours, set task to temporary-failure. 2016-06-08 15:25:57 +01:00
Nicholas Staples
bbd64b088b Added migration to add rate. Tested worked locally. 2016-06-08 10:34:09 +01:00
Chris Hill-Scott
69935f0476 Merge pull request #387 from alphagov/linkify-urls
Make URLs appear as links in email clients
2016-06-07 17:21:57 +01:00
Adam Shimali
29fc470fb5 Merge pull request #392 from alphagov/missing-permissions-fix
[WIP] Permissions being removed
2016-06-07 16:54:59 +01:00
Adam Shimali
e28ef237e4 When adding a user new with permissions to a service, the permissions
dao was deleting all permissions for that user (regardless of service
id) as the last filter on the permissions dao get_query method won.

I've added a replace flag to the set_user_service_permission method
so that it can handle adding new users + permissions and editing
of existing users' permissions.

Also by pass the get_query method until it can be refactored to work
correctly.

For now execute the filter query directly on the model.
2016-06-07 16:35:26 +01:00
Chris Hill-Scott
03192b81c5 Make URLs appear as links in email clients
Implements: https://github.com/alphagov/notifications-utils/pull/42
2016-06-07 16:21:27 +01:00
Leo Hemsted
a3eb4a643e Merge pull request #390 from alphagov/template-statistics-api
add template_statistics endpoint for specific template
2016-06-07 16:12:56 +01:00
Leo Hemsted
e3d9dfad6e add template_statistics endpoint for specific template
`/service/<service_id>/template-statistics/<template_id>`
still requires service-id just to try and keep api tree cleaner
2016-06-07 14:18:42 +01:00
NIcholas Staples
73004a0f74 Merge pull request #389 from alphagov/log_bug_fix
Update log messages so they don't produce an error on the utils logger.
2016-06-07 12:37:25 +01:00
Nicholas Staples
903c479d7a Update log messages so they don't produce an error on the utils logger. 2016-06-07 11:59:13 +01:00
Rebecca Law
dbf6724511 Merge pull request #388 from alphagov/rename-notify-service
Rename notify service to GOV.UK Notify
2016-06-07 10:10:04 +01:00
Rebecca Law
4d072cb113 Rename notify service to GOV.UK Notify 2016-06-07 09:55:10 +01:00
Adam Shimali
207d9088c4 Merge pull request #384 from alphagov/invite-permissions-fix
API receives full set of permission names
2016-06-07 09:36:32 +01:00
Nicholas Staples
fe7d894420 Replaced mmg from number and firetext from number with single from number.
Fix merge mistake.

Fix tests from merge.

Update config to include correct staging and live names.
2016-06-06 16:41:33 +01:00
Rebecca Law
d3c85732bc Merge pull request #383 from alphagov/use-notify-to-send-sms-codes
Use notify to send sms codes
2016-06-06 14:30:25 +01:00
Adam Shimali
63c29a3a3d API recieves full set of permissions names on create of user
invite. This is instead of mapping from permission groups to individual
permissions on user creation.
2016-06-06 12:37:06 +01:00
Rebecca Law
be9fde1420 Fix tests for sending sms codes.
Since the unit tests delete the data in between tests I need to add the template data for the test for send sms code.
2016-06-06 11:51:12 +01:00
Chris Hill-Scott
37a3c27124 Merge pull request #380 from alphagov/bump-utils
Bump utils to latest version
2016-06-06 11:17:26 +01:00
Chris Hill-Scott
e51f6c6916 Merge pull request #378 from alphagov/order-templates-created-at
Order templates by newest created first
2016-06-06 11:17:21 +01:00
Chris Hill-Scott
34740c5827 Bump utils to latest version
This commit doesn’t introduce any new functionality, just keeps things
from getting too far behind.

This is a breaking change in utils, see:
4683922d30

None of these methods are used by the API, so no API code needs to
change, cf:

https://github.com/alphagov/notifications-api/search?utf8=%E2%9C%93&q=rows_with_errors&type=Code
https://github.com/alphagov/notifications-api/search?utf8=%E2%9C%93&q=has_errors&type=Code
https://github.com/alphagov/notifications-api/search?utf8=%E2%9C%93&q=annotated_rows&type=Code
https://github.com/alphagov/notifications-api/search?utf8=%E2%9C%93&q=annotated_rows_with_errors&type=Code
2016-06-06 11:05:32 +01:00
Chris Hill-Scott
c2ae4773da Order templates by newest created first
When you add a new template, it’s probably the one that you want to do
subsequent stuff with. But it’s also helpful to see the template in
context (with its siblings) to understand that there are multiple
templates. So we don’t want to do what we do in
https://github.com/alphagov/notifications-admin/pull/648
for adding a new template.

But we _can_ make your brand-new template appear first by always
ordering by when the template was created.

This also removes the confusion caused by having `updated_at` affecting
order, and causing the templates to move around all the time.
2016-06-06 10:44:40 +01:00
Rebecca Law
dbc57e3b58 [WIP]
use send_sms task to send sms code.
Tests are broken because the template data for the Notify service is being delete after every test. Need a way to seed the data for the test.
2016-06-03 15:15:46 +01:00
Rebecca Law
eae0c252a0 Merge pull request #371 from alphagov/use-notify-to-send-codes
Add a service for Notify to use to send messages
2016-06-03 11:00:04 +01:00
Rebecca Law
ba67b0c89d Change email address of user.
Removed permissions because it not a real user or person.
2016-06-03 10:51:34 +01:00
Rebecca Law
215e96689b Merge branch 'master' into use-notify-to-send-codes 2016-06-03 09:25:21 +01:00
Rebecca Law
811e4e0212 Revert change with setting the id 2016-06-03 09:11:53 +01:00
Leo Hemsted
470ee221b6 Merge pull request #372 from alphagov/delivery-code-statsd
Delivery code statsd
2016-06-02 17:03:29 +01:00
Leo Hemsted
a487931323 python 34 compatibility 2016-06-02 16:49:34 +01:00
Leo Hemsted
54a1adfe8b fix copypasta error with ses test 2016-06-02 16:30:40 +01:00
Leo Hemsted
d41048f4aa statsd counters for callback statuses
also for the 'code' param from firetext
2016-06-02 15:53:04 +01:00
Rebecca Law
4910483f39 Add a service that will be used to send Notify's messages.
Including sms code, email verification, invitation emails, and password reset emails
Added the service id and template ids to config.
Small change to dao_create_service to use id if set.
2016-06-02 15:34:43 +01:00
Leo Hemsted
af89f86389 Merge pull request #368 from alphagov/travis-cache
caching in travis
2016-06-02 12:13:57 +01:00
minglis
db70cf9ebf Merge pull request #360 from alphagov/research-mode-implementation
Research mode implementation
2016-06-02 11:59:47 +01:00
Martyn Inglis
b8638a891f Merge branch 'master' into research-mode-implementation
Conflicts:
	tests/app/conftest.py
2016-06-02 11:53:06 +01:00