Rebecca Law
c8a210afd1
Added a command to re-run the build_dvla_file for a given job id.
...
There was an instance where the file failed to create because the address in the personalisation had punctuation which caused the address lines to merge into one.
Utils has been updated to fix that problem, this task will allow us to re-run the task so that the notifications can be sent.
2017-10-31 15:20:14 +00:00
Rebecca Law
f01c088f2f
Update utils with a fix for address formats for letters.
2017-10-31 15:03:12 +00:00
chrisw
a95d6e8b2e
allow updating auth type
2017-10-31 10:36:53 +00:00
Leo Hemsted
8cb74f5f90
Merge pull request #1352 from alphagov/auth-type
...
Add auth_type column to user and invited user
2017-10-30 17:10:26 +00:00
Richard Chapman
d85a71758c
Retry in only certain scenarios
...
Instead of retrying if there are genuine errors, only retry if there are
errors which are unexpected as otherwise the retries will happen and
fail for the same reason e.g. that the message has changed format and
will require a code update.
- Updated process_ses_results to only retry if there in an unknown
exception
- Update test and assert that there is a retry there is a unknown
exception
2017-10-30 13:43:23 +00:00
Leo Hemsted
7c8586f959
add auth_type to schemas to enable updating in endpoints
2017-10-30 12:29:01 +00:00
Leo Hemsted
c39ec90727
add auth type table, currently contains sms_auth and email_auth
2017-10-30 11:11:37 +00:00
venusbb
b648c2e632
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history
2017-10-30 09:34:23 +00:00
Rebecca Law
f66b7f0a5d
Merge pull request #1350 from alphagov/update-page-counts-for-letters
...
Update page count when processing response file for letters
2017-10-27 16:21:28 +01:00
Leo Hemsted
46f5896b3b
add new email_auth service permission
2017-10-27 14:28:20 +01:00
Rebecca Law
76c8b15f59
Update the billable units with the page count from the response file for letter notifications.
2017-10-27 13:53:55 +01:00
venusbb
6f02ee516c
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history
2017-10-27 10:47:20 +01:00
Rebecca Law
43843eb5d1
Merge pull request #1344 from alphagov/notification_to_sms_sender
...
Create a new table to map a notification to a SMS sender.
2017-10-27 09:51:27 +01:00
venusbb
c991df3209
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history
2017-10-26 20:47:18 +01:00
venusbb
eca93a5a24
added a new end point current-year and tests
2017-10-26 17:21:35 +01:00
Rebecca Law
c9909a4216
Merge pull request #1343 from alphagov/improve-get-services
...
Improve get services
2017-10-26 15:28:56 +01:00
Rebecca Law
4f65ca5447
Create a new table to map a notification to a SMS sender.
...
There is also some minor db model updates here so that the python db model match the db
2017-10-26 15:25:38 +01:00
venusbb
8dd86d433e
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history
2017-10-26 15:02:41 +01:00
venusbb
c10cde6b22
modified serialized method and schema
2017-10-26 13:25:11 +01:00
Richard Chapman
d6cff97b7b
Review Changes
...
- Updated the retry and max_retries of the process_ses_results celery
task to be the same as other retry strategies in that file
- Provided a message with the 200 to be similar to how other responses
are handled
2017-10-26 12:23:19 +01:00
Richard Chapman
c2f2d39d22
Retry process_ses_results if it fails
...
If the SES task fails retry every 5 mins for an hour.
- Updated the process_ses_results task to retry
- Added tests to check for retry
2017-10-26 12:23:19 +01:00
Richard Chapman
0494ef3ea7
Removed the HTTP error and arguments from notification_ses_callback.py
...
In preparation for moving the SNS notification to an SES queue remove
the HTTP errors codes and arguments as the method will now be run by
a celery task. Also made the callback http method return more generic
codes as this will be removed in the longer term.
- Removed errors and arguments returned from process_ses_response
- Updated tests
2017-10-26 12:23:19 +01:00
Rebecca Law
1998034b52
Refactored the get_detailed_services to stop using marshmallow.
...
Also removed an extra query to services.
The query has been refactored to use an outer join to services on the notifications or notification_history table.
The expectation is that this change will improve the performance of the trial/live-services pages for platform admins.
2017-10-26 12:15:52 +01:00
Athanasios Voutsadakis
3443dcea53
Temporary test fix
...
This should be removed when the SES endpoint is removed
2017-10-26 12:14:33 +01:00
Athanasios Voutsadakis
644b31ba75
Update tests
2017-10-26 12:14:33 +01:00
Athanasios Voutsadakis
892eaede13
We no longer have guaranteed access to a request context
2017-10-26 12:14:33 +01:00
Athanasios Voutsadakis
865cb6656e
Allow for both an endpoint callback and SQS consumption
2017-10-26 12:14:33 +01:00
venusbb
e88b311c8e
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history
2017-10-26 11:56:14 +01:00
venusbb
9aa7489655
incorporate reviewers comments
2017-10-26 11:49:56 +01:00
kentsanggds
d39bf96324
Merge pull request #1333 from alphagov/ken-handle-dvla-response-file
...
Handle DVLA response file
2017-10-26 11:09:09 +01:00
Rebecca Law
61a68a2d13
[WIP]
2017-10-25 16:47:39 +01:00
Rebecca Law
4304aad9fc
Merge branch 'master' into improve-get-services
2017-10-25 16:11:35 +01:00
Ken Tsang
204f170de2
Use NOTIFICATION_TECHNICAL_FAILURE not NOTIFICATION_FAILED
2017-10-25 15:39:54 +01:00
Ken Tsang
b40cab0c5d
Refactored models to make const consistent
2017-10-25 15:38:58 +01:00
venusbb
e8f659837a
remove unused codes
2017-10-25 14:52:35 +01:00
Rebecca Law
d4678bc452
Merge pull request #1341 from alphagov/inbound-number-is-the-default-when-only-one
...
Do not create a new SMS sender when allocating an inbound number
2017-10-25 14:02:04 +01:00
Rebecca Law
5ed8f17885
Merge pull request #1338 from alphagov/use-default-sms-not-inbound
...
Use default sms not inbound
2017-10-25 13:39:18 +01:00
Rebecca Law
a8adf4d7d7
This PR is to retain current behaviour when we allocate an inbound number for a service.
...
When a service is allocated an inbound number and they only have one SMS sender, then update that SMS sender to the inbound number.
That way they will not have more than one SMS sender and will not have to choose to use either one.
2017-10-25 11:58:54 +01:00
venusbb
ae6b32d8e2
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history
2017-10-25 11:39:30 +01:00
venusbb
8ad98f2806
create entry when creating a new service
2017-10-25 11:35:13 +01:00
Ken Tsang
5da119f824
Update letter noti status based on dvla response file
2017-10-25 10:48:35 +01:00
Ken Tsang
8bdc999818
Update notification schema to include received letter status
2017-10-25 10:48:35 +01:00
Ken Tsang
a2b42194cd
Add letter status received to data model
...
- in order to reduce the number of statuses in the database the letter status `received` will be mapped to `delivered` internally
2017-10-25 10:48:35 +01:00
Rebecca Law
d1561903ed
[WIP]
...
Removing marshmallow from the get_services endpoint should give us better performance.
2017-10-25 10:40:02 +01:00
venusbb
15e3b4171b
fixed object persistence problem
2017-10-24 16:10:51 +01:00
Chris Hill-Scott
02b2ada174
Merge pull request #1331 from alphagov/better-missing-personalisation-error
...
Make missing personalisation error consistent
2017-10-24 14:46:15 +01:00
venusbb
b9b0814853
Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history
2017-10-24 14:44:32 +01:00
Rebecca Law
8d6c38e1fe
Now that we allow multiple SMS senders for a service, update the sender for SMS to be the default SMS sender, regardless if it is inbound number or not
2017-10-24 13:37:17 +01:00
venusbb
59dd343254
Added free_sms_fragment_limit model, schema, dao and Rest
2017-10-24 13:23:24 +01:00
Rebecca Law
ce13e62d84
Merge pull request #1332 from alphagov/improve-platform-admin
...
Improve platform admin
2017-10-24 10:25:54 +01:00
