darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-30 14:31:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

incorporate reviewers comments

Browse Source
This commit is contained in:
venusbb
2017-10-26 11:49:56 +01:00
parent e8f659837a
commit 9aa7489655
5 changed files with 52 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/dao/annual_billing_dao.py
View File

@@ -34,7 +34,7 @@ def dao_get_all_free_sms_fragment_limit(service_id):
).order_by(AnnualBilling.financial_year_start).all()
def insert_annual_billing(service):
def dao_insert_annual_billing(service):
"""
This method is called from create_service which is wrapped in a transaction.
"""

4
app/dao/services_dao.py
View File

@@ -42,7 +42,7 @@ from app.models import (
from app.service.statistics import format_monthly_template_notification_stats
from app.statsd_decorators import statsd
from app.utils import get_london_month_from_utc_column, get_london_midnight_in_utc
from app.dao.annual_billing_dao import insert_annual_billing
from app.dao.annual_billing_dao import dao_insert_annual_billing
DEFAULT_SERVICE_PERMISSIONS = [
SMS_TYPE,
@@ -181,7 +181,7 @@ def dao_create_service(service, user, service_id=None, service_permissions=None)
service.permissions.append(service_permission)
insert_service_sms_sender(service, service.sms_sender)
insert_annual_billing(service)
dao_insert_annual_billing(service)
db.session.add(service)