Commit Graph

5502 Commits

Author SHA1 Message Date
Cliff Hill
db3761609b Job Status changed.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:33 -05:00
Cliff Hill
69a9accfca Getting NotificationStatus implemented everywhere.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:32 -05:00
Cliff Hill
a177042e77 Formatting cleanup for models.py
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:32 -05:00
Cliff Hill
661904e2cd More fixes for enums.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:32 -05:00
Cliff Hill
f120641087 Getting permission types configured.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:32 -05:00
Cliff Hill
985ad27b3e Getting imports right to use app.enums
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:32 -05:00
Cliff Hill
3982f061b6 Made enums.py for all the enums to avoid cyclic imports.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:31 -05:00
Cliff Hill
ac9591ec7c More tweaks, trying to get tests to be clean.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:31 -05:00
Cliff Hill
908d695b54 More cleanup.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:31 -05:00
Cliff Hill
df866e40f7 More Enum goodness.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:43:27 -05:00
Cliff Hill
43f18eed6a More changes for enums.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:41:57 -05:00
Cliff Hill
820ee5a942 Cleaning up a lot of things, getting Enums used everywhere.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-02-28 12:40:52 -05:00
Carlo Costino
0368307802 Merge pull request #794 from GSA/fix-stats-time-usage
Returned months changed to calendar year
2024-02-27 11:00:17 -05:00
Kenneth Kehl
f301c7a389 If a telephone number is unavailable, change text to 'Unavailable' 2024-02-23 11:07:13 -08:00
Kenneth Kehl
467a2919f4 add log warning in dev environment if phone number is opted out (notify-api-539) 2024-02-13 09:39:53 -08:00
Andrew Shumway
afd77cf9fe Returned months changed to calendar year 2024-02-07 14:53:26 -07:00
Carlo Costino
a70f76c09a Merge pull request #787 from GSA/notify-admin-1159b
update sent_at
2024-02-05 16:56:29 -05:00
Kenneth Kehl
ddad4e409e update send_at when status resolves 2024-02-02 12:51:11 -08:00
Kenneth Kehl
3e6ea3aa2c merge from main 2024-02-02 10:44:29 -08:00
Kenneth Kehl
65bc37d203 fix fstring 2024-02-02 10:29:01 -08:00
Kenneth Kehl
c45e74a74b update sent_at 2024-02-02 09:03:54 -08:00
Kenneth Kehl
82dd29d457 handle bom in phone number field 2024-02-01 12:01:29 -08:00
Kenneth Kehl
a028be238b notify-api-784 remove simulated numbers 2024-02-01 10:48:59 -08:00
Kenneth Kehl
ab71ccde68 fix fstrings 2024-01-31 08:53:54 -08:00
Kenneth Kehl
aecff08d7a remove cache hit/miss writes to log 2024-01-31 08:20:12 -08:00
Kenneth Kehl
fa2b18d5b7 fix logic 2024-01-31 08:10:48 -08:00
Kenneth Kehl
277262ed69 handle error 2024-01-31 08:06:09 -08:00
Kenneth Kehl
363ecb33d5 add debug 2024-01-31 07:25:11 -08:00
Kenneth Kehl
a790c2f9c7 notify-admin-1158 fix email sending 2024-01-26 11:42:30 -08:00
Jonathan Bobel
4ef944d795 1132 - Capitalize "Pending" in delivery reports 2024-01-24 10:56:37 -05:00
Carlo Costino
66b31bc619 Merge pull request #756 from GSA/staging_bug_get_phone
optimize how we look up phone numbers
2024-01-19 12:18:09 -05:00
Kenneth Kehl
a100f60369 code review feedback 2024-01-19 09:02:44 -08:00
Kenneth Kehl
510e67e20b code review feedback 2024-01-18 15:12:52 -08:00
Carlo Costino
ad6aed88a3 Merge pull request #751 from GSA/fix-baseexception
Update try/except block to catch Exception
2024-01-18 17:43:44 -05:00
Kenneth Kehl
797c9f5fc8 remove print statement 2024-01-18 14:06:32 -08:00
Kenneth Kehl
f9120e7d3e optimize how we look up phone numbers 2024-01-18 13:54:23 -08:00
Kenneth Kehl
7997d887c6 fix case sensitivity looking up phone number 2024-01-18 10:53:20 -08:00
Kenneth Kehl
4b98106037 debug 2024-01-18 10:16:14 -08:00
Carlo Costino
4efeb19d02 Update try/except block to catch Exception
This changeset updates a try/except block to catch Exception instead of BaseException.  Using BaseException is an anti-pattern and is not intended for user-defined code; it can also lead to other unintended side effects if not handled properly.

This is enough of a concern that the new release of flake8-bugbear now issues warnings when it sees BaseException being caught without an immediate re-raise.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2024-01-17 22:57:04 -05:00
Kenneth Kehl
c13ed73d23 substitute phone numbers back in when sending data to reports 2024-01-17 09:04:04 -08:00
Kenneth Kehl
848b62092a merge from main 2024-01-16 11:21:54 -08:00
Kenneth Kehl
f9f1013f5b notify-api-742 don't write phone numbers to db 2024-01-16 11:21:24 -08:00
Kenneth Kehl
e45d4dbac9 fix tests 2024-01-12 15:08:59 -08:00
Kenneth Kehl
3414c8e15a fix redis issue causing error in log 2024-01-12 14:28:14 -08:00
Kenneth Kehl
59e8c493e5 add stats for cache hits/misses and remove debug message 2024-01-12 07:30:19 -08:00
Kenneth Kehl
efe4cd589c more debugging messages 2024-01-11 13:22:13 -08:00
Kenneth Kehl
6ab8d556e5 fix case where we dont know the phoneCarrier for any reason 2024-01-11 12:41:24 -08:00
Kenneth Kehl
ab0066589c fix registration and mock tests for redis 2024-01-11 11:51:00 -08:00
Kenneth Kehl
c3cb60f3b0 fix registration so email gets sent 2024-01-11 11:11:12 -08:00
Kenneth Kehl
a8955ef78f fix flake8 2024-01-11 09:50:59 -08:00