darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-20 07:21:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix case sensitivity looking up phone number

Browse Source
This commit is contained in:
Kenneth Kehl
2024-01-18 10:53:20 -08:00
parent 4b98106037
commit 7997d887c6
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/aws/s3.py
View File

@@ -101,12 +101,8 @@ def get_phone_number_from_s3(service_id, job_id, job_row_number):
# At the same time we don't want to store it in redis or the db
# So this is a little recycling mechanism to reduce the number of downloads.
job = JOBS.get(job_id)
# TODO REMOVE
current_app.logger.info(f"HERE IS THE JOB FROM CACHE {job}")
if job is None:
job = get_job_from_s3(service_id, job_id)
# TODO REMOVE
current_app.logger.info(f"HERE IS THE JOB FROM S3 {job}")
JOBS[job_id] = job
incr_jobs_cache_misses()
else:
@@ -118,16 +114,12 @@ def get_phone_number_from_s3(service_id, job_id, job_row_number):
first_row = first_row.split(",")
phone_index = 0
for item in first_row:
if item == "phone number":
if item.lower() == "phone number":
break
phone_index = phone_index + 1
correct_row = job[job_row_number]
correct_row = correct_row.split(",")
# TODO REMOVE
current_app.logger.info(
f"HERE IS THE CORRECT ROW AND PHONE INDEX {correct_row} {phone_index}"
)
# This could happen if an old job cannot be retrieved from s3
if len(correct_row) <= phone_index: