darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-24 01:11:38 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,735 Commits 128 Branches 60 Tags
892eaede132e87d5ecb78c7ef946b0900f04813e
Commit Graph

3735 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Athanasios Voutsadakis
892eaede13 We no longer have guaranteed access to a request context 2017-10-26 12:14:33 +01:00
Athanasios Voutsadakis
865cb6656e Allow for both an endpoint callback and SQS consumption 2017-10-26 12:14:33 +01:00
Richard Chapman
9293a949ea Merge branch 'master' of https://github.com/alphagov/notifications-api 2017-10-26 12:11:48 +01:00
kentsanggds
d39bf96324 Merge pull request #1333 from alphagov/ken-handle-dvla-response-file 
Handle DVLA response file
 2017-10-26 11:09:09 +01:00
Ken Tsang
204f170de2 Use NOTIFICATION_TECHNICAL_FAILURE not NOTIFICATION_FAILED 2017-10-25 15:39:54 +01:00
Ken Tsang
b40cab0c5d Refactored models to make const consistent 2017-10-25 15:38:58 +01:00
Rebecca Law
515a69e8d9 Merge pull request #1339 from alphagov/pyup-update-psycopg2-2.7.3.1-to-2.7.3.2 
Update psycopg2 to 2.7.3.2
 2017-10-25 15:23:45 +01:00
Rebecca Law
fbc0b69685 Merge pull request #1336 from alphagov/pyup-update-marshmallow-sqlalchemy-0.13.1-to-0.13.2 
Update marshmallow-sqlalchemy to 0.13.2
 2017-10-25 15:22:31 +01:00
Rebecca Law
bddbb4bfb8 Merge pull request #1334 from alphagov/pyup-update-notifications-python-client-4.4.0-to-4.5.0 
Update notifications-python-client to 4.5.0
 2017-10-25 15:21:53 +01:00
Rebecca Law
d4678bc452 Merge pull request #1341 from alphagov/inbound-number-is-the-default-when-only-one 
Do not create a new SMS sender when allocating an inbound number
 2017-10-25 14:02:04 +01:00
Rebecca Law
5ed8f17885 Merge pull request #1338 from alphagov/use-default-sms-not-inbound 
Use default sms not inbound
 2017-10-25 13:39:18 +01:00
Rebecca Law
a8adf4d7d7 This PR is to retain current behaviour when we allocate an inbound number for a service. 
When a service is allocated an inbound number and they only have one SMS sender, then update that SMS sender to the inbound number.
That way they will not have more than one SMS sender and will not have to choose to use either one.
 2017-10-25 11:58:54 +01:00
Ken Tsang
ab55650871 Reordered imports 2017-10-25 10:48:35 +01:00
Ken Tsang
5da119f824 Update letter noti status based on dvla response file 2017-10-25 10:48:35 +01:00
Ken Tsang
98d5473788 Update test to to test letter status received 2017-10-25 10:48:35 +01:00
Ken Tsang
8bdc999818 Update notification schema to include received letter status 2017-10-25 10:48:35 +01:00
Ken Tsang
a2b42194cd Add letter status received to data model 
- in order to reduce the number of statuses in the database the letter status `received` will be mapped to `delivered` internally
 2017-10-25 10:48:35 +01:00
pyup-bot
a0de1d0698 Update psycopg2 from 2.7.3.1 to 2.7.3.2 2017-10-24 17:32:05 +01:00
kentsanggds
adfc3b0801 Merge pull request #1337 from alphagov/ken-add-stats-test-for-bst 
Add stats test for BST and fix existing stat test
 2017-10-24 16:37:29 +01:00
Rebecca Law
f519c2a4d9 fix import 2017-10-24 14:53:02 +01:00
Chris Hill-Scott
02b2ada174 Merge pull request #1331 from alphagov/better-missing-personalisation-error 
Make missing personalisation error consistent
 2017-10-24 14:46:15 +01:00
Richard Chapman
bdc1171331 Merge branch 'master' of https://github.com/alphagov/notifications-api 2017-10-24 14:29:25 +01:00
Rebecca Law
8d6c38e1fe Now that we allow multiple SMS senders for a service, update the sender for SMS to be the default SMS sender, regardless if it is inbound number or not 2017-10-24 13:37:17 +01:00
Ken Tsang
9bdb8f10ce Add stats test for bst and fix existing stat test 
- Existing test was failing as the expected results did not match when retrieving results between 11pm and 12am during bst, so time was fixed to when it wasn't affected
- New test is added to check results during the bst hour
 2017-10-24 12:57:15 +01:00
Rebecca Law
ce13e62d84 Merge pull request #1332 from alphagov/improve-platform-admin 
Improve platform admin
 2017-10-24 10:25:54 +01:00
pyup-bot
2e43044a0f Update marshmallow-sqlalchemy from 0.13.1 to 0.13.2 2017-10-24 01:17:28 +01:00
pyup-bot
b16c855f56 Update notifications-python-client from 4.4.0 to 4.5.0 2017-10-23 17:48:27 +01:00
Rebecca Law
5ce44c07f5 Fix unit tests. 2017-10-23 16:07:10 +01:00
Rebecca Law
f1f2e5cd90 Fix the results to be returned in the same format that the admin app expects. 2017-10-23 15:06:11 +01:00
Chris Hill-Scott
5b3e77ba87 Make missing personalisation error consistent 
In other places the text we use for this error message is "Missing personalisation: name, date, thing". See:
- 72b108b694/app/template/rest.py (L125)
- 717c0510a3/app/notifications/rest.py (L206)
- 05a179c6ef/app/v2/template/post_template.py (L38)

For some reason this part of the codebase says "Template missing personalisation: …". This is inconsistent, and also confusing because it’s the API call that’s missing the personalisation, not the template itself. 

This commit changes the error message to be consistent with the majority of the codebase, which uses the less confusing wording.
 2017-10-23 14:41:49 +01:00
Chris Hill-Scott
c9a7ee991e Merge pull request #1328 from alphagov/international-default 
Make international text messaging on by default for new services
 2017-10-23 14:03:16 +01:00
Rebecca Law
bfb8528ea9 The /platform-admin takes a long time, probably because the marshmallow schema used joins to the service table to return all the service data and is inefficient. 
The query itself has not been improved much at all but by not using a marshmallow schema I hope to get the performance gain I am looking for.
 2017-10-23 10:58:06 +01:00
Sakis
f6cdfdb640 Merge pull request #1330 from alphagov/temporary-syslog-drain 
Add syslog drain service to preview and staging
 2017-10-20 14:52:02 +01:00
Katie Smith
3072c66d5f Merge pull request #1329 from alphagov/delete-unused-celery-tasks 
Remove unused Celery tasks
 2017-10-20 14:50:04 +01:00
Rebecca Law
4675b91763 Merge pull request #1325 from alphagov/add-update-multiple-sms-sender 
Add update multiple SMS senders for a service
 2017-10-20 14:06:53 +01:00
Athanasios Voutsadakis
202a0d008b Add syslog drain service to preview and staging 
This should and will be moved back to the approriate manifest-base-*.yml
files when it is configured for production usage.
 2017-10-19 17:08:56 +01:00
Rebecca Law
d1c9335307 If the add sms sender is for an inbound number use the number from the inbound number object, rather than the value passed in. 2017-10-19 16:29:54 +01:00
Katie Smith
ce28e84af6 Remove unused tasks 
Deleted three Celery tasks (send-email, send-sms and persist-letter).

These are not being used anymore - we replaced them in commit
0c9a4bce59.
 2017-10-19 16:17:25 +01:00
Katie Smith
4e1d87bbb4 Merge pull request #1327 from alphagov/create-new-tasks-for-saving-notifications 
Add celery tasks- save_sms, save_email, save_letter
 2017-10-19 16:08:04 +01:00
Rebecca Law
d975f30888 Fix merge conflict 2017-10-19 14:39:53 +01:00
Rebecca Law
954a80649e Merge branch 'master' into add-update-multiple-sms-sender 2017-10-19 14:34:58 +01:00
Venus Bailey
61bda438a4 Merge pull request #1326 from alphagov/vb-free-sms-limit-history 
[#152067121] Create new table annual_billing
 2017-10-19 14:33:44 +01:00
venusbb
b0872d9466 add unique service_id&year constraint 2017-10-19 14:21:10 +01:00
Rebecca Law
2193afe9a3 Remove 'data' from the json being returned. 2017-10-19 13:59:22 +01:00
Rebecca Law
cee916c68a As per review commemnts: 
- Add the assert to a test - oops.
- Fix typo in error message.
 2017-10-19 13:51:33 +01:00
venusbb
7e78e19500 Unique constrain and db.relationship 2017-10-19 12:00:01 +01:00
Chris Hill-Scott
534a2ea7cd Factor permissions tests for code reuse 
We had these fiddly little generator expressions repeated throughout
this file. Code is made easier to understand by refactoring them into a
function that describes what it does.
 2017-10-19 11:43:28 +01:00
Chris Hill-Scott
46d45d8595 Make international SMS on for new services 
International SMS is a mature, documented feature now. There’s no reason
it shouldn’t be available to everyone. If it’s turned off by default
then we’re relying on people finding it in the settings page to know
that it exists (which we found in research the other week that users,
who would have benefitted from having international SMS, were failing to
do).

This also fixes the problem whereby users signing up for Notify with an
international phone number (eg those working abroad for the Foreign and
Commonwealth Office) couldn’t get through the tour because they weren’t
able to send themselves the example text message (see
https://www.pivotaltracker.com/story/show/150705515).
 2017-10-19 11:43:27 +01:00
venusbb
b9bae4f264 Merge branch 'master' of https://github.com/alphagov/notifications-api into vb-free-sms-limit-history 2017-10-19 11:28:46 +01:00
Rebecca Law
709e24e267 Added endpoints to get sms senders for a service 2017-10-19 10:43:49 +01:00