Commit Graph

5620 Commits

Author SHA1 Message Date
Carlo Costino
ad6aed88a3 Merge pull request #751 from GSA/fix-baseexception
Update try/except block to catch Exception
2024-01-18 17:43:44 -05:00
Kenneth Kehl
797c9f5fc8 remove print statement 2024-01-18 14:06:32 -08:00
Kenneth Kehl
f9120e7d3e optimize how we look up phone numbers 2024-01-18 13:54:23 -08:00
Kenneth Kehl
7997d887c6 fix case sensitivity looking up phone number 2024-01-18 10:53:20 -08:00
Kenneth Kehl
4b98106037 debug 2024-01-18 10:16:14 -08:00
Kenneth Kehl
567dd390b4 fix personalisation 2024-01-18 10:03:35 -08:00
Carlo Costino
4efeb19d02 Update try/except block to catch Exception
This changeset updates a try/except block to catch Exception instead of BaseException.  Using BaseException is an anti-pattern and is not intended for user-defined code; it can also lead to other unintended side effects if not handled properly.

This is enough of a concern that the new release of flake8-bugbear now issues warnings when it sees BaseException being caught without an immediate re-raise.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2024-01-17 22:57:04 -05:00
Kenneth Kehl
c13ed73d23 substitute phone numbers back in when sending data to reports 2024-01-17 09:04:04 -08:00
Kenneth Kehl
848b62092a merge from main 2024-01-16 11:21:54 -08:00
Kenneth Kehl
f9f1013f5b notify-api-742 don't write phone numbers to db 2024-01-16 11:21:24 -08:00
Kenneth Kehl
e45d4dbac9 fix tests 2024-01-12 15:08:59 -08:00
Kenneth Kehl
3414c8e15a fix redis issue causing error in log 2024-01-12 14:28:14 -08:00
Kenneth Kehl
59e8c493e5 add stats for cache hits/misses and remove debug message 2024-01-12 07:30:19 -08:00
Kenneth Kehl
efe4cd589c more debugging messages 2024-01-11 13:22:13 -08:00
Kenneth Kehl
6ab8d556e5 fix case where we dont know the phoneCarrier for any reason 2024-01-11 12:41:24 -08:00
Kenneth Kehl
ab0066589c fix registration and mock tests for redis 2024-01-11 11:51:00 -08:00
Kenneth Kehl
c3cb60f3b0 fix registration so email gets sent 2024-01-11 11:11:12 -08:00
Kenneth Kehl
a8955ef78f fix flake8 2024-01-11 09:50:59 -08:00
Kenneth Kehl
131eff475a merge from main 2024-01-11 09:43:58 -08:00
Kenneth Kehl
ea8caf1ad9 remove debugging for 2fa issue 2024-01-11 09:38:00 -08:00
Carlo Costino
6332399b5b Really make sure Redis is enabled
This changeset should cover the rest of the missing pieces to make sure Redis connectivity is truly established in the API app.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
2024-01-11 12:05:07 -05:00
Kenneth Kehl
6f04915ee8 flake8 2024-01-10 11:20:33 -08:00
Kenneth Kehl
7b2e59dede switch to raw_get and raw_set to see exceptions 2024-01-10 10:30:44 -08:00
Kenneth Kehl
3dcb8d194e more debug 2024-01-10 09:10:52 -08:00
Kenneth Kehl
572c8ebb84 reformat 2024-01-09 14:45:11 -08:00
Kenneth Kehl
2f9b98c07e debug messages 2024-01-09 14:28:24 -08:00
Kenneth Kehl
5366992d1a format 2024-01-09 14:01:03 -08:00
Kenneth Kehl
d3ca06fec2 fix 2024-01-09 13:36:57 -08:00
Kenneth Kehl
be950a7322 no verification code on staging 2024-01-09 13:09:07 -08:00
Carlo Costino
52272d78da Merge pull request #707 from GSA/notify-api-685f
get phone numbers from the jobs in s3
2024-01-08 18:07:33 -05:00
Kenneth Kehl
726e0b15fa code review feedback 2024-01-08 14:31:28 -08:00
Kenneth Kehl
a5f78224b2 remove print statements 2024-01-05 10:39:07 -08:00
Kenneth Kehl
88379c9e46 final 2024-01-05 10:35:14 -08:00
Carlo Costino
e0bf936420 Merge pull request #704 from GSA/API-312_Make_Multiple_Opt_Out_Lists_Pinpoint
Clean up client classes
2024-01-04 15:52:00 -05:00
Cliff Hill
b88d1f0aa2 Minor tweaks
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-01-04 15:07:50 -05:00
Cliff Hill
d714ebcd5d Restructured how clients are implemented.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2024-01-04 09:00:41 -05:00
Cliff Hill
3ff6d38660 Making the new pinpoint client.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2023-12-29 18:11:55 -05:00
Cliff Hill
8461b336ca Fixing bug.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2023-12-29 09:56:17 -05:00
Carlo Costino
81907bb80e Merge pull request #659 from GSA/ADMIN-97_Resend_Expired_Invites
Admin 97 resend expired invites
2023-12-20 14:05:41 -05:00
Cliff Hill
affc5e7aff Fixing stuff.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2023-12-20 09:51:43 -05:00
Cliff Hill
ff70dc9b8b Filtering the rest endpoint for resending invites by status = pending
now.

Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2023-12-20 08:15:19 -05:00
Cliff Hill
61d294292b Did stuff, fixed things. This seems to work now.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2023-12-15 13:14:53 -05:00
Carlo Costino
a616437375 Merge pull request #676 from GSA/Change-default-Text-message-sender-from-U.S.-Notify-to-Notify.gov#446
Change default Text message sender from U.S. Notify to Notify.gov #446
2023-12-13 17:19:22 -05:00
Cliff Hill
b72ae4374f Working on tests.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2023-12-13 10:14:14 -05:00
Beverly Nguyen
bf11d77775 change from_number 2023-12-12 15:55:45 -08:00
Cliff Hill
81b5afc983 Fixing tests.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2023-12-12 09:13:43 -05:00
Beverly Nguyen
86fb725060 added extra parentheses 2023-12-11 14:47:46 -08:00
Cliff Hill
e4f228ca0d More test fixes.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2023-12-08 22:01:27 -05:00
Cliff Hill
1157f5639d black, isort, flake8
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2023-12-08 21:43:52 -05:00
Cliff Hill
1fdad3099b Working on tests.
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
2023-12-08 13:15:40 -05:00