Commit Graph

4544 Commits

Author SHA1 Message Date
kentsanggds
4773e1b51b Merge pull request #1617 from alphagov/ken-set-page-count-0-fake-dvla-response
Update the dvla response data to 0 page count
2018-02-05 10:48:28 +00:00
Rebecca Law
a2c7acd1ac Merge pull request #1620 from alphagov/fix-despro-ticket
Fix bug with sending deskpro tickets in production.
2018-02-02 11:42:03 +00:00
Rebecca Law
cf8be03c5e Fix bug with sending deskpro tickets in production.
The NOTIFY_ENVIRONMENT variable is set to `production` from the run_paas_app script, but that is overwritten with `live` in the create_app function when starting an application.
Although this is confusing and it would be good to resolve that. It is a larger piece of work. For now I have included booth strings in the if condition, that way when we do migrate the code we will not have an issue with these two methods.
2018-02-02 11:27:58 +00:00
Chris Hill-Scott
5349736781 Merge pull request #1618 from alphagov/pyup-update-pytest-3.3.2-to-3.4.0
Update pytest to 3.4.0
2018-01-31 14:17:11 +00:00
pyup-bot
041c9ee9b5 Update pytest from 3.3.2 to 3.4.0 2018-01-30 23:19:54 +00:00
Leo Hemsted
800fbb4c6e Merge pull request #1613 from alphagov/international-500
fix 500 when receiving delivery receipt from some international nums
2018-01-30 13:58:39 +00:00
Leo Hemsted
3d389472b8 fix 500 when receiving delivery receipt from some international nums
if the international_billing_rates.yml has `dlr: null`, that means we
don't know what delivery receipts they provide - they might not provide
any. So if we do get an update, we don't know for sure that the message
was actually delivered - lets not update it.
2018-01-30 12:08:18 +00:00
Chris Hill-Scott
aab05ac8f1 Merge pull request #1600 from alphagov/letters-for-new-services
Turn letters on by default for new services
2018-01-30 11:07:55 +00:00
Chris Hill-Scott
3ec8008d67 Merge pull request #1616 from alphagov/ea-letter-org
Add letter logo for environment agency
2018-01-30 10:41:20 +00:00
Chris Hill-Scott
f0f3e03931 Add letter logo for environment agency
Depends on:
https://github.com/alphagov/notifications-template-preview/pull/87
2018-01-29 17:29:24 +00:00
Ken Tsang
9122efc45e Update the dvla response data to 0 page count
- as the response is fake, the notifications billable_unit is left at 0, the fake dvla response should also be 0. Otherwise there will be confusing logs reporting mismatched page count and billable units which are just research ones.
2018-01-29 16:39:53 +00:00
kentsanggds
24e890fad5 Merge pull request #1614 from alphagov/ken-remove-redundant-sent-dvla-task
Remove sent to dvla task
2018-01-29 16:04:20 +00:00
Ken Tsang
54835b56e1 Remove sent to dvla task
- task not really necessary as the status is already set to 'sending' before the task is called if it is not sending i.e. in reseach mode or using a test key
2018-01-29 14:34:22 +00:00
kentsanggds
014f738a3d Merge pull request #1609 from alphagov/ken-refactor-letter-research-process
Refactor letter research processing for letter pdfs
2018-01-26 16:39:53 +00:00
Ken Tsang
5ef9b426bb Update letter notification processing for letter pdfs in research mode
- calls create fake response file to allow functional tests to run and trigger update of status to delivered only on preview and development so that FT response files don't pollute staging and live buckets
2018-01-26 15:05:02 +00:00
Ken Tsang
377afc3ed4 Update letter processing for letter pdfs in research mode
- call create fake response file task if in research mode only on preview and development environments to not impact response files on staging and live
2018-01-26 15:04:56 +00:00
Ken Tsang
c14452d8b1 Add create fake letter response file
- used by letter functional tests to ensure that we can create the response file necessary to trigger the update to a delivered state
2018-01-26 14:45:36 +00:00
Ken Tsang
04beff7d05 Return sorted ACK files
- also fixes unit test failure due to random order of filenames
2018-01-26 14:45:36 +00:00
Ken Tsang
edd030e5dd Refactor code to move business logic
- DVLA specific logic is now moved to letters_pdf_tasks
2018-01-26 14:45:36 +00:00
Richard Chapman
8740f16b96 Merge pull request #1607 from alphagov/rc_change_task_exectution_time
Changed the time of the daily-stats-template-usage-by-month task to run at 00:05
2018-01-26 12:59:54 +00:00
Richard Chapman
f171ba37c0 Merge pull request #1605 from alphagov/pyup-update-awscli-1.14.25-to-1.14.31
Update awscli to 1.14.31
2018-01-26 12:59:40 +00:00
Richard Chapman
6660598030 Merge pull request #1604 from alphagov/pyup-update-boto3-1.5.15-to-1.5.21
Update boto3 to 1.5.21
2018-01-26 10:12:38 +00:00
Richard Chapman
957da05b3e Merge pull request #1602 from alphagov/pyup-update-sqlalchemy-1.2.1-to-1.2.2
Update sqlalchemy to 1.2.2
2018-01-26 10:12:11 +00:00
Richard Chapman
49d69a84d9 Changed the time of the task to run at 00:05 as the query gets data for
the day before 0:00, so to minimise the report being out of date run the
query at 0:05.
2018-01-26 09:56:53 +00:00
Richard Chapman
741d859d44 Merge pull request #1606 from alphagov/rc_remove_statsd_decorators
Removed the performance testing statsd calls
2018-01-26 09:48:17 +00:00
Richard Chapman
eee572276f Removed the imports for statsd as the decorators are no longer being
used.
2018-01-26 09:39:11 +00:00
Richard Chapman
083bfb9ea5 Removed the performance testing statsd calls as they are no longer
needed for monitoring the performance of the v2 endpoints. They were put
in as a temporary measure whilst sustained performance testing was
taking place.
2018-01-26 09:08:45 +00:00
pyup-bot
6b51498056 Update awscli from 1.14.25 to 1.14.31 2018-01-26 00:09:55 +00:00
pyup-bot
39fc7d7001 Update boto3 from 1.5.15 to 1.5.21 2018-01-26 00:09:46 +00:00
Sakis
f784cc69ad Merge pull request #1603 from alphagov/remove-staging-syslog-drain
Remove syslog drain from staging
2018-01-25 13:26:00 +00:00
Athanasios Voutsadakis
b02d13e8e1 Remove syslog drain from staging 2018-01-25 13:11:36 +00:00
Richard Chapman
fa06196ca4 Merge pull request #1601 from alphagov/rc_separate_delivery_app_for_internal_tasks
Create a separate delivery app to consume the notify-internal-tasks
2018-01-25 12:35:37 +00:00
pyup-bot
c7a3cf01fc Update sqlalchemy from 1.2.1 to 1.2.2 2018-01-25 02:45:44 +00:00
Richard Chapman
d2693b6499 Tasks that are put on the notify-internal-tasks queue are notifications
sent by the notify service, including 2FA and email auth messages.
These should never be delayed by other messages in the queue.

Created a separate delivery app to consume the notify-internal-tasks
queue and only that queue.
2018-01-24 17:12:26 +00:00
Ken Tsang
3355a29d01 Ensure letter personalisation is serialized correctly
The personalisation for letters can take different formats depending on
how the letter was generated, for example it can contain either
address_line_1 or addressline1. This change ensures that it is always
serialized in the same way.
2018-01-24 16:44:14 +00:00
Chris Hill-Scott
e9aba34c5e Turn letters on by default for new services
Letters is a mature enough feature now – and one that we’ve been talking
about offering for long enough – that we shouldn’t make people dig
around in the settings.

I think we’d want to wait a bit longer/indefinitely before deciding to
turn it on for existing services across the platform.
2018-01-24 13:42:11 +00:00
Venus Bailey
b1cbe9db86 Merge pull request #1598 from alphagov/letter-deskpro-ack-mod
Minor change to raising deskpro ticket and errors when letter acknowl…
2018-01-23 11:43:26 +00:00
Venus Bailey
82e34f7699 Merge branch 'master' into letter-deskpro-ack-mod 2018-01-23 11:32:49 +00:00
Katie Smith
5fc85f1827 Merge pull request #1580 from alphagov/update-dvla-response-process
Process the new post printing response file from DVLA
2018-01-23 10:24:53 +00:00
venusbb
8cb8de8664 changed tests 2018-01-23 10:13:56 +00:00
venusbb
d93b0d12d1 Minor change to raising deskpro ticket and errors when letter acknowledgement fails. 2018-01-23 09:51:43 +00:00
Katie Smith
84e25d6b98 Compare letter page count with billable units in DVLA response file
We compare the page_count in the response file we receive from the DVLA
with the billable_units of the letter. If these don't match, we log an
error.
2018-01-23 08:59:01 +00:00
Katie Smith
f1c75c5c5d Change notification status of failed letters
- Changed the notification status of letters for letters that DVLA marks
as 'failed' from NOTIFICATION_TECHNICAL_FAILURE to
NOTIFICATION_TEMPORARY_FAILURE.
2018-01-23 08:59:01 +00:00
Ken Tsang
6a3c2734ca Update callback handling to process DVLA response files
- handle `RS.TXT` and `RSP.TXT` files
2018-01-23 08:59:01 +00:00
Venus Bailey
9629a69353 Merge pull request #1595 from alphagov/letter_ack_send_deskpro_prod_only
Processing ack files only send alerts in production environment.
2018-01-22 17:11:09 +00:00
venusbb
6c384342fd Merge branch 'letter_ack_send_deskpro_prod_only' of https://github.com/alphagov/notifications-api into letter_ack_send_deskpro_prod_only 2018-01-22 14:56:32 +00:00
venusbb
125b810050 Merge branch 'master' of https://github.com/alphagov/notifications-api into letter_ack_send_deskpro_prod_only 2018-01-22 14:54:06 +00:00
Venus Bailey
cc237b4273 Merge branch 'master' into letter_ack_send_deskpro_prod_only 2018-01-22 14:53:55 +00:00
venusbb
2edb0c0883 Grammar change to despro ticket
Grammar change to despro ticket
Strip sets of empty elements
Strip subfolder in returned zip file list
ar change to despro ticket
2018-01-22 14:51:06 +00:00
Chris Hill-Scott
930f28be0f Merge pull request #1593 from alphagov/stricter-phone
Be stricter about length of phone numbers
2018-01-22 13:52:32 +00:00