Commit Graph

994 Commits

Author SHA1 Message Date
Rebecca Law
470bf7281a Merge pull request #420 from alphagov/use-notify-to-send-email-verification-links
Use notify to send email verification links
2016-06-14 17:00:28 +01:00
Rebecca Law
4c34238a88 Fix send_email task requested from notifications endpoint. 2016-06-14 16:53:52 +01:00
Rebecca Law
92e7450d1d Revert after_deploy task to after_success 2016-06-14 16:30:23 +01:00
Rebecca Law
91f64c41c2 Use after_deploy to run functional tests. 2016-06-14 16:11:50 +01:00
Rebecca Law
6c8e108982 Merge pull request #379 from alphagov/remove_twilio_config_variables
Twilio config variables removed.
2016-06-14 15:54:06 +01:00
Rebecca Law
a55b44a333 Merge pull request #412 from alphagov/use-notify-to-send-email-verification-links
Safely change task signature - first deploy
2016-06-14 15:42:59 +01:00
Chris Hill-Scott
3b7135f276 Merge pull request #413 from alphagov/filter-job-notifications
Test for filtering a job by notification status
2016-06-14 15:31:24 +01:00
Chris Hill-Scott
7f7743b389 Test for filtering a job by notification status
It’s going to be useful to see all the notifications for a job that are
failed/delivered/etc.

The API seems to support this behaviour already, but it doesn’t seem to
be tested.

This commit adds some testsfor the DAO and REST layers.
2016-06-14 14:07:54 +01:00
Rebecca Law
b31c4e801e Remove old email_registration_verification task 2016-06-14 11:43:13 +01:00
minglis
14e2487266 Merge pull request #415 from alphagov/update-notify-from-address
moved migration script from
2016-06-14 09:28:05 +01:00
Martyn Inglis
d5259be44c moved migration script from
https://github.com/alphagov/notifications-api/pull/412

To ship it quickly as preview broken without it.
2016-06-14 09:22:07 +01:00
Rebecca Law
a6ce109c62 Rename first send_email to send_email_v1.
Fix the tests
2016-06-13 16:16:56 +01:00
Rebecca Law
cd2627e5ed Create a new task called send_email_v2 so that I can get rid of the from_address in the signature.
This is done to make sure we do not lose any messages in the queue during deployment.
2016-06-13 15:31:45 +01:00
Rebecca Law
6299e5b9df Merge pull request #411 from alphagov/use-notify-to-send-email-verification-links
Use notify to send email verification links
2016-06-13 15:21:32 +01:00
Adam Shimali
da45a997f3 Merge pull request #410 from alphagov/better-error-logging
Better error logging
2016-06-13 15:05:17 +01:00
Rebecca Law
5fc14940f3 Let the send_email task set the from address 2016-06-13 14:58:00 +01:00
Rebecca Law
c9f1eb65a7 Build the from address in the task instead of the rest call. 2016-06-13 14:57:59 +01:00
Rebecca Law
ea80596e73 Correct template id for email verification template in the history table.
Correct personalisation name when sending registration message.
2016-06-13 14:57:59 +01:00
Rebecca Law
877fd6fdc4 Make template id a string in the json messge 2016-06-13 14:57:59 +01:00
Rebecca Law
cfd31541f4 Use notify to send email verification 2016-06-13 14:57:41 +01:00
Adam Shimali
3d55c47d1e Rest methods that explicitly return errors by pass the error handlers as
they do not raise exceptions.

Introduced a simple exception that contains error messages and status
code that can be used rather than return json + status code from rest
methods directly.

The handler in errors for this exception can then log the error before
returning json.
2016-06-13 13:50:35 +01:00
Rebecca Law
b677768de1 Merge pull request #400 from alphagov/remove-task-send-sms-code
Remove task send_sms_code.
2016-06-13 11:34:26 +01:00
Nicholas Staples
dd9a7f09c5 Twilio config variables removed. 2016-06-13 08:39:33 +01:00
Leo Hemsted
59497fde17 Merge pull request #405 from alphagov/dashboard-slowdown
exclude notifications from job
2016-06-10 16:45:05 +01:00
Leo Hemsted
edc72a57ca add test file for schemas 2016-06-10 16:34:20 +01:00
Leo Hemsted
7083be429a exclude notifications from job
was being lazily loaded to get notification ids, so every time a job is loaded it would potentially select thousands of notifications from the database
2016-06-10 15:37:05 +01:00
Leo Hemsted
d0d2d0dbc8 Merge pull request #402 from alphagov/firetext-research-400s
fix firetext research mode requests
2016-06-09 15:25:00 +01:00
Leo Hemsted
fd2a0a0b10 fix firetext research mode requests
requests converts dicts into query parameters anyway if you don't specify so dont try and encode the data ourselves, also hardened up tests
2016-06-09 15:15:44 +01:00
Leo Hemsted
c14cb5c291 Merge pull request #399 from alphagov/order-template-api
fix template api tests being inconsistent by adding ordering
2016-06-09 11:59:33 +01:00
Rebecca Law
50ec2eb7fc Remove task send_sms_code.
We use a notify service to send the sms code via using a template.
2016-06-09 11:54:34 +01:00
Leo Hemsted
3e72440f38 fix template api tests being inconsistent by adding ordering 2016-06-09 11:24:04 +01:00
Leo Hemsted
511e65b9f9 Merge pull request #398 from alphagov/firetext-log
log firetext extended error codes
2016-06-09 10:46:01 +01:00
NIcholas Staples
964fd5ac35 Merge pull request #377 from alphagov/single_from_number
Replaced mmg from number and firetext from number with single from nu…
2016-06-09 10:41:39 +01:00
Leo Hemsted
6926769f66 log firetext response code 2016-06-09 10:35:07 +01:00
NIcholas Staples
9e73675f67 Merge pull request #396 from alphagov/set_provider_rates
Added migration to add rate. Tested worked locally.
2016-06-08 16:18:06 +01:00
NIcholas Staples
e783010e59 Merge pull request #397 from alphagov/timeout_sending_msgs
Task added to update 'sending' notifications after 72 hours, set task…
2016-06-08 16:16:59 +01:00
Nicholas Staples
8a1f4de217 Task added to update 'sending' notifications after 72 hours, set task to temporary-failure. 2016-06-08 15:25:57 +01:00
Nicholas Staples
bbd64b088b Added migration to add rate. Tested worked locally. 2016-06-08 10:34:09 +01:00
Chris Hill-Scott
69935f0476 Merge pull request #387 from alphagov/linkify-urls
Make URLs appear as links in email clients
2016-06-07 17:21:57 +01:00
Adam Shimali
29fc470fb5 Merge pull request #392 from alphagov/missing-permissions-fix
[WIP] Permissions being removed
2016-06-07 16:54:59 +01:00
Adam Shimali
e28ef237e4 When adding a user new with permissions to a service, the permissions
dao was deleting all permissions for that user (regardless of service
id) as the last filter on the permissions dao get_query method won.

I've added a replace flag to the set_user_service_permission method
so that it can handle adding new users + permissions and editing
of existing users' permissions.

Also by pass the get_query method until it can be refactored to work
correctly.

For now execute the filter query directly on the model.
2016-06-07 16:35:26 +01:00
Chris Hill-Scott
03192b81c5 Make URLs appear as links in email clients
Implements: https://github.com/alphagov/notifications-utils/pull/42
2016-06-07 16:21:27 +01:00
Leo Hemsted
a3eb4a643e Merge pull request #390 from alphagov/template-statistics-api
add template_statistics endpoint for specific template
2016-06-07 16:12:56 +01:00
Leo Hemsted
e3d9dfad6e add template_statistics endpoint for specific template
`/service/<service_id>/template-statistics/<template_id>`
still requires service-id just to try and keep api tree cleaner
2016-06-07 14:18:42 +01:00
NIcholas Staples
73004a0f74 Merge pull request #389 from alphagov/log_bug_fix
Update log messages so they don't produce an error on the utils logger.
2016-06-07 12:37:25 +01:00
Nicholas Staples
903c479d7a Update log messages so they don't produce an error on the utils logger. 2016-06-07 11:59:13 +01:00
Rebecca Law
dbf6724511 Merge pull request #388 from alphagov/rename-notify-service
Rename notify service to GOV.UK Notify
2016-06-07 10:10:04 +01:00
Rebecca Law
4d072cb113 Rename notify service to GOV.UK Notify 2016-06-07 09:55:10 +01:00
Adam Shimali
207d9088c4 Merge pull request #384 from alphagov/invite-permissions-fix
API receives full set of permission names
2016-06-07 09:36:32 +01:00
Nicholas Staples
fe7d894420 Replaced mmg from number and firetext from number with single from number.
Fix merge mistake.

Fix tests from merge.

Update config to include correct staging and live names.
2016-06-06 16:41:33 +01:00