Commit Graph

1327 Commits

Author SHA1 Message Date
Leo Hemsted
1e8ab35976 Merge branch 'master' into noti-stats-cleanup 2016-08-24 14:24:17 +01:00
minglis
cf14c97ebb Merge pull request #618 from alphagov/template_useage_per_id
Template useage per
2016-08-24 11:01:17 +01:00
Martyn Inglis
3006c7af54 Removed print 2016-08-24 10:59:33 +01:00
Martyn Inglis
acf3c568db Tidied up the query indentation 2016-08-24 10:50:29 +01:00
Andras Ferencz-Szabo
9926df7c08 Merge pull request #626 from alphagov/jenkins_deploy_stage
Disable Travis deploys for staging
2016-08-23 16:56:48 +01:00
bandesz
e6177a2163 Disable Travis deploys for staging 2016-08-23 16:45:21 +01:00
Andras Ferencz-Szabo
e2c028c752 Merge pull request #625 from alphagov/jenkins_deploy_dev
Fix version file generation, remove master deploys from travis
2016-08-23 14:07:28 +01:00
bandesz
f113309713 Fix version file generation, remove master deploys from travis 2016-08-23 13:44:34 +01:00
Leo Hemsted
270451e7ba Merge pull request #617 from alphagov/update-branding
update ukvi org branding spelling
2016-08-23 10:25:34 +01:00
Leo Hemsted
132addb181 Merge branch 'master' into noti-stats-cleanup 2016-08-23 09:49:12 +01:00
Martyn Inglis
fe22c876b6 Merge branch 'master' into template_useage_per_id 2016-08-23 09:32:01 +01:00
Andras Ferencz-Szabo
0b73da94e7 Merge pull request #605 from alphagov/jenkins_deploy
Create Docker build image, build project with Docker
2016-08-22 17:57:39 +01:00
bandesz
68c1135379 Create Docker build image, build project with Docker 2016-08-22 17:25:41 +01:00
minglis
cbdabb14fe Merge pull request #610 from alphagov/template_queryies
Template queryies
2016-08-22 16:39:30 +01:00
Leo Hemsted
d7945d85dc update ukvi org branding spelling
was previously UK Visas and Immigration
now UK Visas & Immigration
2016-08-22 16:12:09 +01:00
Leo Hemsted
31f260d793 Merge pull request #614 from alphagov/utils-vers
actually bump version
2016-08-22 14:51:18 +01:00
Leo Hemsted
0a052d45a8 actually bump version
missed a number last time 😧
2016-08-22 14:40:02 +01:00
Martyn Inglis
4e6da1ba55 Changed template stats for template id
- now returns the most recent notification history row for that template ID.
- contains all the required data for the use cases for that template
2016-08-22 14:35:04 +01:00
Leo Hemsted
997dd47911 Merge pull request #612 from alphagov/utils-vers
update utils version
2016-08-22 13:44:40 +01:00
Leo Hemsted
d5ec73bc8a update utils version 2016-08-22 13:38:45 +01:00
Martyn Inglis
fdd85b7dc0 Merge branch 'master' into template_queryies 2016-08-22 11:42:26 +01:00
Leo Hemsted
5418f65ae7 Merge pull request #599 from alphagov/version-500
fix GET /notifications 500 error
2016-08-22 10:59:46 +01:00
Martyn Inglis
b7476a1975 Removed the group by day aspects of template stats. Not needed. Grouped by template only. 2016-08-22 10:38:44 +01:00
Martyn Inglis
9eb559d4b2 Renamed the param to avoid shadowing 2016-08-18 15:29:56 +01:00
Martyn Inglis
ede7d0cbea Removed old endpoint.
Going to handle the migration in the clients.
2016-08-18 14:06:12 +01:00
Martyn Inglis
7a5acea71b New endpoint for template stats to use new query. Breaking change to the returned JSON, so adding on a different url. 2016-08-18 14:01:31 +01:00
Martyn Inglis
f74000f548 Add query to get template usage from the Notifications History table
- groups by template Id and Day.

Returns count per day, template name, template id, template type, and day.

Ordered by day (desc) and template name (acc)
2016-08-18 12:06:00 +01:00
minglis
c684fa2b8f Merge pull request #607 from alphagov/set_app_name_for_delivery
Missing the name on the aws start celery command
2016-08-17 13:45:34 +01:00
Martyn Inglis
989fbb094d Missing the name on the aws start celery command
- means that logs are branded as application:api not delivery.
2016-08-17 13:18:33 +01:00
minglis
7fab5ada38 Merge pull request #596 from alphagov/extend-timeout-on-db-retries
Improve logging and extend time periods associated with retrying
2016-08-17 09:24:49 +01:00
Leo Hemsted
721929ca75 Merge pull request #589 from alphagov/org-rendering
Render organisational branding in emails
2016-08-16 13:26:09 +01:00
Leo Hemsted
5491668579 let users set organisation on POST /service/{id} 2016-08-15 10:54:26 +01:00
Leo Hemsted
cc7ea8043c add organisation and branding to GET /service response dict 2016-08-12 11:40:57 +01:00
Leo Hemsted
5b3a0f03d3 rename actual_template to template_history
it's slightly less emotionally charged
2016-08-12 10:29:23 +01:00
Leo Hemsted
8fb0ba56ed unused schema 2016-08-11 17:30:50 +01:00
Leo Hemsted
b22e3845aa kill unused schema 2016-08-11 16:34:36 +01:00
Leo Hemsted
f065b08db2 remove unused dao functions 2016-08-11 16:13:53 +01:00
Leo Hemsted
fff81b4910 remove unused notification-statistics endpoints 2016-08-11 11:55:28 +01:00
Chris Hill-Scott
a0838166d4 Merge pull request #600 from alphagov/better-error-messages
Give better error messages when using the API to send to recipients not in your team
2016-08-11 10:29:01 +01:00
Chris Hill-Scott
ebfaa5dac2 Show separate error messages for team key
Although using a team key is functionally the same as your service being
restricted, conflating the two errors is not helpful. What we typically
saw in research was that someone was using a team key, got the error,
used a live key and got the _same_ error.

This commit adds a new error message that specifically mentions the type
of API key that you’re using.
2016-08-10 16:20:01 +01:00
Chris Hill-Scott
0a429e18b4 Give better error when sending to non-team member
Scenario we saw in research:
- trying to send a message to someone outside your team
- service is in trial mode

Result:
- error message was terrible, no-one understood it

Solution:
- better error message
2016-08-10 16:17:47 +01:00
Leo Hemsted
4dd924d438 Merge branch 'master' into version-500 2016-08-10 14:55:07 +01:00
Leo Hemsted
c7f6cdc661 Merge pull request #595 from alphagov/content-char-count
re-add Content char count
2016-08-10 12:24:14 +01:00
Leo Hemsted
52b2f4f583 require fields in marshmallow schema to try and make it as hard
to break backwards compatability as possible
2016-08-10 11:27:28 +01:00
Martyn Inglis
67a4ee7d51 In event of a task retry ensure the log message is identifier as such
- "RETRY" prefixes the messages

In event of the retry attempts completing without successfully completing the task identify message as such

- "RETRY FAILED" prefixes the messages

Applies to the send_sms|send_email and send_sms_to_provider|send_email_to_provider tasks

These are there to try and ensure we can alert on these events so that we know if we have started retrying messages

Retry messages also contain notification ids to aid debugging.
2016-08-10 08:53:15 +01:00
Martyn Inglis
5b8fbada11 Extend the retry time on the create notification DB tasks
- Was previoulsy 5 attempts 5 seconds apart
- No 5 times 5 minutes apart.
- Gives 25 mins of retries before an error
2016-08-10 08:46:37 +01:00
Leo Hemsted
f184bb7996 add test for notification status return value
to ensure we never break compatibility
2016-08-09 17:31:38 +01:00
Leo Hemsted
5b7af00295 re-add content_char_count to public GET /notification endpoints
we shouldn't remove stuff from endpoints or we'll break clients
2016-08-09 17:30:38 +01:00
Leo Hemsted
648b4a17c8 remove xfail flag - the test passes properly now! 🎉 2016-08-09 16:57:18 +01:00
Leo Hemsted
4ba3745159 update schema to use template_history for accurate template details
only in the public notification endpoint so far for fear of breaking
things - in an ideal world i'd remove the template relationship
from models entirely and replace that with actual_template
2016-08-09 16:57:18 +01:00