Commit Graph

3361 Commits

Author SHA1 Message Date
Katie Smith
132d65bc75 Add query to get processing time stats for performance platform
We are only interested in API notifications, not including test
messages. Letters are not included.
2017-08-30 14:40:10 +01:00
Katie Smith
9df498106f Add one_off argument to create_notification test function
One off messages have no API key or job ID. If one_off is set to False,
an API key will automatically be added.
2017-08-30 14:40:10 +01:00
Leo Hemsted
5c25b12b0f Merge pull request #1201 from alphagov/parallel-db-tests
run tests in multiple threads at once
2017-08-30 09:42:39 +01:00
Leo Hemsted
2fefe8a957 use sqlalchemy hooks rather than pyscopg2
seems to play nicer with docker?
2017-08-29 18:03:15 +01:00
Leo Hemsted
3d4dbaa632 run tests in multiple threads at once
previously we didn't do this because the tests all used the same DB
(test_notifications_api), however @minglis shared a snippet that simply
creates one test db per thread.
2017-08-29 17:46:11 +01:00
Chris Hill-Scott
4f0443041d Merge pull request #1213 from alphagov/remove-spec
Remove Swagger specification
2017-08-29 14:19:31 +01:00
Leo Hemsted
cf2d803db1 Merge pull request #1205 from alphagov/perf-stats
Perf stats refactor
2017-08-29 10:44:09 +01:00
Chris Hill-Scott
d0be79cc4c Remove Swagger specification
This was only ever a spike into what it might look like to document
Notify’s API with Swagger (see
7c3d25a87a).
It’s no longer updated, and only talks about version 1 of the public
API.

Keeping it around now is just a liability, and gives us additional Pyup
upgrades to deal with.
2017-08-29 10:32:37 +01:00
Chris Hill-Scott
8642ee9f53 Merge pull request #1216 from alphagov/pyup-update-moto-1.0.1-to-1.1.1
Update moto to 1.1.1
2017-08-29 09:45:37 +01:00
pyup-bot
ace28f2e85 Update moto from 1.0.1 to 1.1.1 2017-08-26 08:17:55 +01:00
Leo Hemsted
741210d5b4 Merge pull request #1214 from alphagov/letters-v1
make sure letters are handled properly by the v1 api
2017-08-25 17:00:55 +01:00
Leo Hemsted
c863b33c8d make sure letters are handled properly by the v1 api 2017-08-25 16:47:17 +01:00
Leo Hemsted
23fdbe2897 Merge pull request #1212 from alphagov/logging
Letter fixes and multi-process logging
2017-08-25 15:02:34 +01:00
Leo Hemsted
4e7c19a98f update utils to v20 - log from multiple app.log*.json files
the rotating file handler puts the date on the end, so those old files won't be pushed
2017-08-25 14:38:04 +01:00
kentsanggds
549601a6df Merge pull request #1200 from alphagov/ken-refactor-inbound_numbers
Refactor inbound numbers
2017-08-25 13:27:16 +01:00
Chris Hill-Scott
6848a50ae1 Bump utils to 19.0.4
Brings in:
- [ ] https://github.com/alphagov/notifications-utils/pull/210
- [ ] https://github.com/alphagov/notifications-utils/pull/212
2017-08-25 09:36:43 +01:00
Chris Hill-Scott
73d1154661 Merge pull request #1210 from alphagov/nbsp-fix
Bump utils to 19.0.2
2017-08-24 17:40:31 +01:00
Chris Hill-Scott
ce2c157f8f Bump utils to 19.0.2
Brings in:
- [ ] https://github.com/alphagov/notifications-utils/pull/211
2017-08-24 17:11:46 +01:00
Leo Hemsted
e85b621cbc make perf platform client handle more stuff sensibly
specifically, all of the performance platform specific data layout now
happens in performance_platform_client.py - stuff like setting the
_timestamp, period etc, and the perf platform-specific nomenclature is
all handled there.
2017-08-24 17:10:42 +01:00
Rebecca Law
f9ee8bba91 Merge pull request #1209 from alphagov/remove-unused-endpoint
Removed unused endpoint and dao methods.
2017-08-24 16:32:37 +01:00
Rebecca Law
717c0510a3 Merge pull request #1202 from alphagov/v1-send-letter-error-msg
Added a proper error response if the notification type is not supported.
2017-08-24 16:31:21 +01:00
Rebecca Law
17f62723fa Removed unused endpoint and dao methods. 2017-08-24 16:09:48 +01:00
kentsanggds
aeb817614f Merge pull request #1204 from alphagov/ken-fix-scheduled-letter-job
Made celery task arg a tuple
2017-08-24 15:15:16 +01:00
Ken Tsang
1b35731fb2 Refactor code
- updated dao_get_letter_jobs_by_status to dao_get_letter_job_ids_by_status to return array of strings
2017-08-24 11:57:46 +01:00
Leo Hemsted
7a6c6c4855 Merge pull request #1208 from alphagov/pyup-ignore
make pyup ignore flask-bcrypt
2017-08-24 11:40:42 +01:00
Leo Hemsted
336ee69f02 make pyup ignore flask-bcrypt
pyup is trying to upgrade flask-bcrypt, which causes errors in all subsequent PR builds for #reasons. Lets make pyup ignore flask-bcrypt until we figure out why the upgrade doesn't work
2017-08-24 11:16:21 +01:00
Leo Hemsted
412c87cfc8 pycodestyle 2017-08-24 10:52:47 +01:00
Leo Hemsted
1f93fc889c add new cf performance-platform service to manifest 2017-08-23 18:21:54 +01:00
Leo Hemsted
bd2682b521 add new performance-platform section to cf config
it's a new cf-service we've got to create, that contains endpoints
and the bearer tokens for them.
2017-08-23 18:14:35 +01:00
Ken Tsang
451c5a9f1a Made celery task arg a tuple 2017-08-23 18:05:48 +01:00
Leo Hemsted
89f4f5173e refactor performance platform code
so that it doesn't appear generic when it's actually specific to
sending the daily notification totals. To do this, split it out into a
separate performance_platform directory, containing the business logic,
and make the performance_platform_client incredibly thin - all it
handles is adding ids to payloads, and sending stats.

Also, some changes to the config (not all done yet) since there is one
token per endpoint, not one for the whole platform as we'd previously
coded
2017-08-23 17:37:29 +01:00
Rebecca Law
7aaef8fc09 Merge pull request #1197 from alphagov/bump-utils-19.0.0
Bump utils to 19.0.0
2017-08-23 16:55:46 +01:00
Rebecca Law
d4422dd35f Added a proper error response if the notification type is not supported. 2017-08-23 14:56:03 +01:00
Ken Tsang
d99ab329eb Refactored code to use inbound_number.number
- Removed filter on sms_sender for `dao_fetch_services_by_inbound_number`
2017-08-23 14:14:32 +01:00
Ken Tsang
fb2623962f Moved create_inbound after dao_create_service
- Need to do this otherwise no service.id is available to link the servce to the inbound number
2017-08-23 14:03:41 +01:00
kentsanggds
3794722203 Merge pull request #1196 from alphagov/ken-add-scheduled-letter-job
Add scheduled letter job
2017-08-23 13:52:25 +01:00
Ken Tsang
c3ce828635 Updated letter jobs schedule to 5:30pm 2017-08-23 13:22:07 +01:00
Ken Tsang
665420402e Improved code style 2017-08-23 13:22:07 +01:00
Ken Tsang
4fb5e68ce7 Refactor code
- Created TaskNames for DVLA_FILES rather than have DVLA_FILES in QueueNames
- Removed PROCESS_FTP from all_queues() as this was causing problems in picking up letter job tasks
- Created test to ensure that we don't arbitrarily add queue names to all_queues
2017-08-23 13:22:07 +01:00
Ken Tsang
41fce57932 Removed PROCESS_FTP from all_queues 2017-08-23 13:22:07 +01:00
Ken Tsang
b2b74e2b5d Fixed bug in letter job schedule 2017-08-23 13:22:07 +01:00
Ken Tsang
62172ce39b Updated schedule to run at 5:15pm 2017-08-23 13:22:07 +01:00
Ken Tsang
bd79a6f770 Improved tests on letter jobs by status 2017-08-23 13:22:07 +01:00
Ken Tsang
18881cd580 Add scheduled letter jobs 2017-08-23 13:22:07 +01:00
Ken Tsang
8c4a084a0d Refactor letters filename 2017-08-23 13:22:07 +01:00
Rebecca Law
5b43c0af79 Merge branch 'master' into bump-utils-19.0.0 2017-08-23 10:56:25 +01:00
Rebecca Law
f84bbf530b Bump utils to 19.0.1
To eliminate flask deprecation warnings.
2017-08-23 10:55:56 +01:00
Rebecca Law
789492060c Merge pull request #1198 from alphagov/fix-redis-error
Stop redis cache from throwing an error
2017-08-23 09:38:20 +01:00
Leo Hemsted
12cf36f6fa Merge pull request #1142 from alphagov/log-ip-block
log ip address as separate field to allow analysis of messages
2017-08-22 17:01:54 +01:00
Rebecca Law
029daf1820 Added an assert that the set cache method is not called if the cache values are empty 2017-08-22 16:43:22 +01:00