darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-27 02:41:23 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,531 Commits 126 Branches 60 Tags
05b378f606bcbf88ddced2044c2bc708ce40d732
Commit Graph

4531 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
pyup-bot
05b378f606 Update boto3 from 1.5.21 to 1.5.22 2018-01-26 23:39:47 +00:00
kentsanggds
014f738a3d Merge pull request #1609 from alphagov/ken-refactor-letter-research-process 
Refactor letter research processing for letter pdfs
 2018-01-26 16:39:53 +00:00
Ken Tsang
5ef9b426bb Update letter notification processing for letter pdfs in research mode 
- calls create fake response file to allow functional tests to run and trigger update of status to delivered only on preview and development so that FT response files don't pollute staging and live buckets
 2018-01-26 15:05:02 +00:00
Ken Tsang
377afc3ed4 Update letter processing for letter pdfs in research mode 
- call create fake response file task if in research mode only on preview and development environments to not impact response files on staging and live
 2018-01-26 15:04:56 +00:00
Ken Tsang
c14452d8b1 Add create fake letter response file 
- used by letter functional tests to ensure that we can create the response file necessary to trigger the update to a delivered state
 2018-01-26 14:45:36 +00:00
Ken Tsang
04beff7d05 Return sorted ACK files 
- also fixes unit test failure due to random order of filenames
 2018-01-26 14:45:36 +00:00
Ken Tsang
edd030e5dd Refactor code to move business logic 
- DVLA specific logic is now moved to letters_pdf_tasks
 2018-01-26 14:45:36 +00:00
Richard Chapman
8740f16b96 Merge pull request #1607 from alphagov/rc_change_task_exectution_time 
Changed the time of the daily-stats-template-usage-by-month task to run at 00:05
 2018-01-26 12:59:54 +00:00
Richard Chapman
f171ba37c0 Merge pull request #1605 from alphagov/pyup-update-awscli-1.14.25-to-1.14.31 
Update awscli to 1.14.31
 2018-01-26 12:59:40 +00:00
Richard Chapman
6660598030 Merge pull request #1604 from alphagov/pyup-update-boto3-1.5.15-to-1.5.21 
Update boto3 to 1.5.21
 2018-01-26 10:12:38 +00:00
Richard Chapman
957da05b3e Merge pull request #1602 from alphagov/pyup-update-sqlalchemy-1.2.1-to-1.2.2 
Update sqlalchemy to 1.2.2
 2018-01-26 10:12:11 +00:00
Richard Chapman
49d69a84d9 Changed the time of the task to run at 00:05 as the query gets data for 
the day before 0:00, so to minimise the report being out of date run the
query at 0:05.
 2018-01-26 09:56:53 +00:00
Richard Chapman
741d859d44 Merge pull request #1606 from alphagov/rc_remove_statsd_decorators 
Removed the performance testing statsd calls
 2018-01-26 09:48:17 +00:00
Richard Chapman
eee572276f Removed the imports for statsd as the decorators are no longer being 
used.
 2018-01-26 09:39:11 +00:00
Richard Chapman
083bfb9ea5 Removed the performance testing statsd calls as they are no longer 
needed for monitoring the performance of the v2 endpoints. They were put
in as a temporary measure whilst sustained performance testing was
taking place.
 2018-01-26 09:08:45 +00:00
pyup-bot
6b51498056 Update awscli from 1.14.25 to 1.14.31 2018-01-26 00:09:55 +00:00
pyup-bot
39fc7d7001 Update boto3 from 1.5.15 to 1.5.21 2018-01-26 00:09:46 +00:00
Sakis
f784cc69ad Merge pull request #1603 from alphagov/remove-staging-syslog-drain 
Remove syslog drain from staging
 2018-01-25 13:26:00 +00:00
Athanasios Voutsadakis
b02d13e8e1 Remove syslog drain from staging 2018-01-25 13:11:36 +00:00
Richard Chapman
fa06196ca4 Merge pull request #1601 from alphagov/rc_separate_delivery_app_for_internal_tasks 
Create a separate delivery app to consume the notify-internal-tasks
 2018-01-25 12:35:37 +00:00
pyup-bot
c7a3cf01fc Update sqlalchemy from 1.2.1 to 1.2.2 2018-01-25 02:45:44 +00:00
Richard Chapman
d2693b6499 Tasks that are put on the notify-internal-tasks queue are notifications 
sent by the notify service, including 2FA and email auth messages.
These should never be delayed by other messages in the queue.

Created a separate delivery app to consume the notify-internal-tasks
queue and only that queue.
 2018-01-24 17:12:26 +00:00
Ken Tsang
3355a29d01 Ensure letter personalisation is serialized correctly 
The personalisation for letters can take different formats depending on
how the letter was generated, for example it can contain either
address_line_1 or addressline1. This change ensures that it is always
serialized in the same way.
 2018-01-24 16:44:14 +00:00
Venus Bailey
b1cbe9db86 Merge pull request #1598 from alphagov/letter-deskpro-ack-mod 
Minor change to raising deskpro ticket and errors when letter acknowl…
 2018-01-23 11:43:26 +00:00
Venus Bailey
82e34f7699 Merge branch 'master' into letter-deskpro-ack-mod 2018-01-23 11:32:49 +00:00
Katie Smith
5fc85f1827 Merge pull request #1580 from alphagov/update-dvla-response-process 
Process the new post printing response file from DVLA
 2018-01-23 10:24:53 +00:00
venusbb
8cb8de8664 changed tests 2018-01-23 10:13:56 +00:00
venusbb
d93b0d12d1 Minor change to raising deskpro ticket and errors when letter acknowledgement fails. 2018-01-23 09:51:43 +00:00
Katie Smith
84e25d6b98 Compare letter page count with billable units in DVLA response file 
We compare the page_count in the response file we receive from the DVLA
with the billable_units of the letter. If these don't match, we log an
error.
 2018-01-23 08:59:01 +00:00
Katie Smith
f1c75c5c5d Change notification status of failed letters 
- Changed the notification status of letters for letters that DVLA marks
as 'failed' from NOTIFICATION_TECHNICAL_FAILURE to
NOTIFICATION_TEMPORARY_FAILURE.
 2018-01-23 08:59:01 +00:00
Ken Tsang
6a3c2734ca Update callback handling to process DVLA response files 
- handle `RS.TXT` and `RSP.TXT` files
 2018-01-23 08:59:01 +00:00
Venus Bailey
9629a69353 Merge pull request #1595 from alphagov/letter_ack_send_deskpro_prod_only 
Processing ack files only send alerts in production environment.
 2018-01-22 17:11:09 +00:00
venusbb
6c384342fd Merge branch 'letter_ack_send_deskpro_prod_only' of https://github.com/alphagov/notifications-api into letter_ack_send_deskpro_prod_only 2018-01-22 14:56:32 +00:00
venusbb
125b810050 Merge branch 'master' of https://github.com/alphagov/notifications-api into letter_ack_send_deskpro_prod_only 2018-01-22 14:54:06 +00:00
Venus Bailey
cc237b4273 Merge branch 'master' into letter_ack_send_deskpro_prod_only 2018-01-22 14:53:55 +00:00
venusbb
2edb0c0883 Grammar change to despro ticket 
Grammar change to despro ticket
Strip sets of empty elements
Strip subfolder in returned zip file list
ar change to despro ticket
 2018-01-22 14:51:06 +00:00
Chris Hill-Scott
930f28be0f Merge pull request #1593 from alphagov/stricter-phone 
Be stricter about length of phone numbers
 2018-01-22 13:52:32 +00:00
Chris Hill-Scott
c6e4aee80a Be stricter about length of phone numbers 
Brings in:
- [x] https://github.com/alphagov/notifications-utils/pull/319
 2018-01-22 13:37:47 +00:00
Chris Hill-Scott
83dd7ef156 Merge pull request #1581 from alphagov/dont-allow-whitelist-in-one-off 
Don’t respect the whitelist for one off sending
 2018-01-22 13:35:49 +00:00
venusbb
a87a17b996 Grammar change to despro ticket 2018-01-22 13:11:47 +00:00
venusbb
cf30e69e8c Processing ack files only send alerts in production environment. 
Processing ack files only send alerts in production environment.
Deskpro alerts include bucket names for debugging purpose.
 2018-01-22 12:44:03 +00:00
Chris Hill-Scott
01cf175cb2 Don’t respect the whitelist for one off sending 
The whitelist was built to help developers and designers making
prototypes to do realistic usability testing of them, without having to
go through the whole go live process.

These users are sending messages using the API. The whitelist wasn’t
made available to users uploading spreadsheets. The users sending one
off messages are similar to those uploading spreadsheets, not those
using the API. Therefore they shouldn’t be able to use the whitelist to
expand the range of recipients they can send to.

Passing the argument through three methods doesn’t feel that great, but
can’t think of a better way without major refactoring…
 2018-01-22 11:42:37 +00:00
Venus Bailey
2018660d12 Merge pull request #1589 from alphagov/letter-S3zipchange-deskpro 
Fix a date time format problem - need to use AWS S3 format
 2018-01-19 15:56:22 +00:00
Venus Bailey
5480dba44f Merge branch 'master' into letter-S3zipchange-deskpro 2018-01-19 14:40:05 +00:00
Rebecca Law
5029e4cb1f Merge pull request #1590 from alphagov/raise-400-for-validation-error 
Raise 400 for a validation error
 2018-01-19 13:56:00 +00:00
Rebecca Law
8a126bbfbb Merge branch 'master' into raise-400-for-validation-error 2018-01-19 13:41:24 +00:00
Rebecca Law
93ce1d2503 There were some exceptions in production today where a one off message was sending a message with an invalid email address. 
The admin app validation did not catch this problem. But the API did.
This PR is a small fix to catch the erorr thrown by the notifications-utils/recipient validation methods and return a 400 status rather than a 500.
This only solves the issue of the user seeing "We are experiencing technical difficulties" rather than "invalid email address"

The bug can be replicated if you enter use quotes when entering the email address.

More work needs to be done so that the admin app does the same validation as the api so the user sees a nice form validtion error rather than a 400 after clicking send.
See: https://www.pivotaltracker.com/story/show/154472625
 2018-01-19 12:23:07 +00:00
venusbb
4ffb84de36 Comparison of date needs to use AWS S3 format 2018-01-19 09:24:03 +00:00
Venus Bailey
db29874948 Merge pull request #1588 from alphagov/letter-S3zipchange-deskpro 
Process letter acknowledge file with new S3 zip file meta file structure
 2018-01-18 15:27:14 +00:00
venusbb
6a790b59aa Merge branch 'master' of https://github.com/alphagov/notifications-api into letter-S3zipchange-deskpro 2018-01-18 14:45:04 +00:00