darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-20 15:31:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor for reuse

Browse Source 
Makes one resuable function, instead of 3 repetetive ones.
This commit is contained in:
Chris Hill-Scott
2019-09-25 13:57:06 +01:00
parent 1e82484dfb
commit f63565695a
1 changed files with 7 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
app/dao/organisation_dao.py
View File

@@ -80,43 +80,24 @@ def dao_update_organisation(organisation_id, **kwargs):
organisation = Organisation.query.get(organisation_id)
if 'organisation_type' in kwargs:
_update_org_type_for_organisation_services(organisation)
_update_organisation_services(organisation, 'organisation_type', only_where_none=False)
if 'email_branding_id' in kwargs:
_update_email_branding_for_organisation_services(organisation)
_update_organisation_services(organisation, 'email_branding')
if 'letter_branding_id' in kwargs:
_update_letter_branding_for_organisation_services(organisation)
_update_organisation_services(organisation, 'letter_branding')
return num_updated
@version_class(
VersionOptions(Service, must_write_history=False)
VersionOptions(Service, must_write_history=False),
)
def _update_org_type_for_organisation_services(organisation):
def _update_organisation_services(organisation, attribute, only_where_none=True):
for service in organisation.services:
service.organisation_type = organisation.organisation_type
db.session.add(service)
@version_class(
VersionOptions(Service, must_write_history=False)
)
def _update_email_branding_for_organisation_services(organisation):
for service in organisation.services:
if service.email_branding is None:
service.email_branding = organisation.email_branding
db.session.add(service)
@version_class(
VersionOptions(Service, must_write_history=False)
)
def _update_letter_branding_for_organisation_services(organisation):
for service in organisation.services:
if service.letter_branding is None:
service.letter_branding = organisation.letter_branding
if getattr(service, attribute) is None or not only_where_none:
setattr(service, attribute, getattr(organisation, attribute))
db.session.add(service)