darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

clients: cbc_proxy client uses _ld not _lambda

Browse Source 
_ld is better than _lambda because it causes primitive python syntax
highlighting to not get confused

_lambda is better than _ld because it is less jargon

Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
Co-authored-by: Pea <pea.tyczynska@digital.cabinet-office.gov.uk>
Co-authored-by: Katie <katie.smith@digital.cabinet-office.gov.uk>
This commit is contained in:
Toby Lorne
2020-10-20 13:59:52 +01:00
parent 14f8e7a5ff
commit ee79768d43
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/clients/cbc_proxy.py
View File

@@ -33,7 +33,7 @@ class CBCProxyNoopClient:
class CBCProxyClient: class CBCProxyClient:
def init_app(self, app): def init_app(self, app):
self._lambda_client = boto3.client( self._ld_client = boto3.client(
'lambda', 'lambda',
region_name='eu-west-2', region_name='eu-west-2',
aws_access_key_id=app.config['CBC_PROXY_AWS_ACCESS_KEY_ID'], aws_access_key_id=app.config['CBC_PROXY_AWS_ACCESS_KEY_ID'],

10
tests/app/clients/test_cbc_proxy.py
View File

@@ -14,14 +14,14 @@ def cbc_proxy(client, mocker):
return client return client
def test_cbc_proxy_lambda_client_has_correct_region(cbc_proxy): def test_cbc_proxy_ld_client_has_correct_region(cbc_proxy):
assert cbc_proxy._lambda_client._client_config.region_name == 'eu-west-2' assert cbc_proxy._ld_client._client_config.region_name == 'eu-west-2'
pass pass
def test_cbc_proxy_lambda_client_has_correct_keys(cbc_proxy): def test_cbc_proxy_ld_client_has_correct_keys(cbc_proxy):
key = cbc_proxy._lambda_client._request_signer._credentials.access_key key = cbc_proxy._ld_client._request_signer._credentials.access_key
secret = cbc_proxy._lambda_client._request_signer._credentials.secret_key secret = cbc_proxy._ld_client._request_signer._credentials.secret_key
assert key == 'cbc-proxy-aws-access-key-id' assert key == 'cbc-proxy-aws-access-key-id'
assert secret == 'cbc-proxy-aws-secret-access-key' assert secret == 'cbc-proxy-aws-secret-access-key'