From ee79768d431a71a73b500b0bcbaca3175cecb347 Mon Sep 17 00:00:00 2001 From: Toby Lorne Date: Tue, 20 Oct 2020 13:59:52 +0100 Subject: [PATCH] clients: cbc_proxy client uses _ld not _lambda _ld is better than _lambda because it causes primitive python syntax highlighting to not get confused _lambda is better than _ld because it is less jargon Signed-off-by: Toby Lorne Co-authored-by: Pea Co-authored-by: Katie --- app/clients/cbc_proxy.py | 2 +- tests/app/clients/test_cbc_proxy.py | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/clients/cbc_proxy.py b/app/clients/cbc_proxy.py index 2405c67f5..5bf3655b2 100644 --- a/app/clients/cbc_proxy.py +++ b/app/clients/cbc_proxy.py @@ -33,7 +33,7 @@ class CBCProxyNoopClient: class CBCProxyClient: def init_app(self, app): - self._lambda_client = boto3.client( + self._ld_client = boto3.client( 'lambda', region_name='eu-west-2', aws_access_key_id=app.config['CBC_PROXY_AWS_ACCESS_KEY_ID'], diff --git a/tests/app/clients/test_cbc_proxy.py b/tests/app/clients/test_cbc_proxy.py index 34bc89b0c..58ed5b8c6 100644 --- a/tests/app/clients/test_cbc_proxy.py +++ b/tests/app/clients/test_cbc_proxy.py @@ -14,14 +14,14 @@ def cbc_proxy(client, mocker): return client -def test_cbc_proxy_lambda_client_has_correct_region(cbc_proxy): - assert cbc_proxy._lambda_client._client_config.region_name == 'eu-west-2' +def test_cbc_proxy_ld_client_has_correct_region(cbc_proxy): + assert cbc_proxy._ld_client._client_config.region_name == 'eu-west-2' pass -def test_cbc_proxy_lambda_client_has_correct_keys(cbc_proxy): - key = cbc_proxy._lambda_client._request_signer._credentials.access_key - secret = cbc_proxy._lambda_client._request_signer._credentials.secret_key +def test_cbc_proxy_ld_client_has_correct_keys(cbc_proxy): + key = cbc_proxy._ld_client._request_signer._credentials.access_key + secret = cbc_proxy._ld_client._request_signer._credentials.secret_key assert key == 'cbc-proxy-aws-access-key-id' assert secret == 'cbc-proxy-aws-secret-access-key'