darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-31 23:26:23 -05:00
Code Issues Packages Projects Releases Wiki Activity

Updated schema to handle null updated_at

Browse Source
This commit is contained in:
Ken Tsang
2017-03-15 15:48:28 +00:00
parent 7558a7661a
commit ea8a3754a0
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/v2/template/template_schemas.py
View File

@@ -29,7 +29,7 @@ get_template_by_id_response = {
},
"updated_at": {
"format": "date-time",
"type": "string",
"type": ["string", "null"],
"description": "Date+time updated"
},
"created_by": {"type": "string"},

10
tests/app/v2/template/test_template_schemas.py
View File

@@ -15,7 +15,7 @@ valid_json = {
'id': str(uuid.uuid4()),
'type': 'email',
'created_at': '2017-01-10T18:25:43.511Z',
'updated_at': '2017-04-23T18:25:43.511Z',
'updated_at': None,
'version': 1,
'created_by': 'someone@test.com',
'body': "some body"
@@ -25,7 +25,7 @@ valid_json_with_optionals = {
'id': str(uuid.uuid4()),
'type': 'email',
'created_at': '2017-01-10T18:25:43.511Z',
'updated_at': '2017-04-23T18:25:43.511Z',
'updated_at': None,
'version': 1,
'created_by': 'someone',
'body': "some body",
@@ -62,5 +62,9 @@ def test_get_template_request_schema_against_invalid_args_is_invalid(args, error
@pytest.mark.parametrize("response", [valid_json, valid_json_with_optionals])
def test_get_template_response_schema_is_valid(response):
@pytest.mark.parametrize("updated_datetime", [None, '2017-01-11T18:25:43.511Z'])
def test_get_template_response_schema_is_valid(response, updated_datetime):
if updated_datetime:
response['updated_at'] = updated_datetime
assert validate(response, get_template_by_id_response) == response