darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 08:51:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update broadcast approval alert content

Browse Source 
This now links to the new runbook for the alert.
This commit is contained in:
Ben Thorner
2022-04-05 12:31:10 +01:00
parent 779b8e941f
commit e84014b86d
2 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/broadcast_message/utils.py
View File

@@ -74,13 +74,12 @@ def _create_p1_zendesk_alert(broadcast_message):
https://www.notifications.service.gov.uk/services/{broadcast_message.service_id}/current-alerts/{broadcast_message.id} https://www.notifications.service.gov.uk/services/{broadcast_message.service_id}/current-alerts/{broadcast_message.id}
This broacast has been sent on channel {broadcast_message.service.broadcast_channel}. Sent on channel {broadcast_message.service.broadcast_channel} to {broadcast_message.areas["names"]}.
This broadcast is targeted at areas {broadcast_message.areas.get("names", [])}.
This broadcast's content starts "{broadcast_message.content[:100]}". Content starts "{broadcast_message.content[:100]}".
If this alert is not expected refer to the runbook for instructions. Follow the runbook to check the broadcast went out OK:
https://docs.google.com/document/d/1J99yOlfp4nQz6et0w5oJVqi-KywtIXkxrEIyq_g2XUs https://docs.google.com/document/d/1J99yOlfp4nQz6et0w5oJVqi-KywtIXkxrEIyq_g2XUs/edit#heading=h.lzr9aq5b4wg
""".strip() """.strip()
ticket = NotifySupportTicket( ticket = NotifySupportTicket(

5
tests/app/broadcast_message/test_utils.py
View File

@@ -414,9 +414,8 @@ def test_create_p1_zendesk_alert(sample_broadcast_service, mocker, notify_api):
assert ticket.subject == 'Live broadcast sent' assert ticket.subject == 'Live broadcast sent'
assert ticket.ticket_type == 'incident' assert ticket.ticket_type == 'incident'
assert str(broadcast_message.id) in ticket.message assert str(broadcast_message.id) in ticket.message
assert 'channel severe' in ticket.message assert "Sent on channel severe to ['England', 'Scotland']" in ticket.message
assert "areas ['England', 'Scotland']" in ticket.message assert 'Content starts "tailor made emergency' in ticket.message
assert "tailor made emergency" in ticket.message
def test_create_p1_zendesk_alert_doesnt_alert_when_cancelling(mocker, notify_api, sample_broadcast_service): def test_create_p1_zendesk_alert_doesnt_alert_when_cancelling(mocker, notify_api, sample_broadcast_service):