From e84014b86dd2e7a73617df1692243b49014820b4 Mon Sep 17 00:00:00 2001 From: Ben Thorner Date: Tue, 5 Apr 2022 12:31:10 +0100 Subject: [PATCH] Update broadcast approval alert content This now links to the new runbook for the alert. --- app/broadcast_message/utils.py | 9 ++++----- tests/app/broadcast_message/test_utils.py | 5 ++--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/app/broadcast_message/utils.py b/app/broadcast_message/utils.py index 3707db1d2..e9e6c4c18 100644 --- a/app/broadcast_message/utils.py +++ b/app/broadcast_message/utils.py @@ -74,13 +74,12 @@ def _create_p1_zendesk_alert(broadcast_message): https://www.notifications.service.gov.uk/services/{broadcast_message.service_id}/current-alerts/{broadcast_message.id} - This broacast has been sent on channel {broadcast_message.service.broadcast_channel}. - This broadcast is targeted at areas {broadcast_message.areas.get("names", [])}. + Sent on channel {broadcast_message.service.broadcast_channel} to {broadcast_message.areas["names"]}. - This broadcast's content starts "{broadcast_message.content[:100]}". + Content starts "{broadcast_message.content[:100]}". - If this alert is not expected refer to the runbook for instructions. - https://docs.google.com/document/d/1J99yOlfp4nQz6et0w5oJVqi-KywtIXkxrEIyq_g2XUs + Follow the runbook to check the broadcast went out OK: + https://docs.google.com/document/d/1J99yOlfp4nQz6et0w5oJVqi-KywtIXkxrEIyq_g2XUs/edit#heading=h.lzr9aq5b4wg """.strip() ticket = NotifySupportTicket( diff --git a/tests/app/broadcast_message/test_utils.py b/tests/app/broadcast_message/test_utils.py index d13246693..c604821be 100644 --- a/tests/app/broadcast_message/test_utils.py +++ b/tests/app/broadcast_message/test_utils.py @@ -414,9 +414,8 @@ def test_create_p1_zendesk_alert(sample_broadcast_service, mocker, notify_api): assert ticket.subject == 'Live broadcast sent' assert ticket.ticket_type == 'incident' assert str(broadcast_message.id) in ticket.message - assert 'channel severe' in ticket.message - assert "areas ['England', 'Scotland']" in ticket.message - assert "tailor made emergency" in ticket.message + assert "Sent on channel severe to ['England', 'Scotland']" in ticket.message + assert 'Content starts "tailor made emergency' in ticket.message def test_create_p1_zendesk_alert_doesnt_alert_when_cancelling(mocker, notify_api, sample_broadcast_service):