darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-24 01:11:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor test into loop

Browse Source 
This makes it less repetitive, and will let us add more assertions for
each month that we’re checking.
This commit is contained in:
Chris Hill-Scott
2017-02-07 12:47:07 +00:00
parent 85b441b445
commit dd2e754730
1 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
tests/app/dao/test_services_dao.py
View File

@@ -526,23 +526,25 @@ def test_fetch_monthly_historical_stats_separates_weeks(notify_db, notify_db_ses
result = dao_fetch_monthly_historical_stats_for_service(sample_template.service_id, 2016)
assert result['2016-04']['sms']['created'] == 1
assert result['2016-04']['sms']['sending'] == 0
assert result['2016-04']['sms']['delivered'] == 0
assert result['2016-04']['sms']['pending'] == 0
assert result['2016-04']['sms']['failed'] == 0
assert result['2016-04']['sms']['technical-failure'] == 0
assert result['2016-04']['sms']['temporary-failure'] == 0
assert result['2016-04']['sms']['permanent-failure'] == 0
for date, status, count in (
('2016-04', 'sending', 0),
('2016-04', 'delivered', 0),
('2016-04', 'pending', 0),
('2016-04', 'failed', 0),
('2016-04', 'technical-failure', 0),
('2016-04', 'temporary-failure', 0),
('2016-04', 'permanent-failure', 0),
assert result['2016-06']['sms']['created'] == 1
('2016-06', 'created', 1),
assert result['2016-10']['sms']['created'] == 1
('2016-10', 'created', 1),
assert result['2016-12']['sms']['created'] == 0
assert result['2016-12']['sms']['delivered'] == 1
('2016-12', 'created', 0),
('2016-12', 'delivered', 1),
assert result['2017-03']['sms']['created'] == 2
('2017-03', 'created', 2),
):
assert result[date]['sms'][status] == count
assert result.keys() == {
'2016-04', '2016-05', '2016-06',