darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-31 15:15:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Processing ack files only send alerts in production environment.

Browse Source 
Processing ack files only send alerts in production environment.
Deskpro alerts include bucket names for debugging purpose.
This commit is contained in:
venusbb
2018-01-22 12:44:03 +00:00
parent 2018660d12
commit cf30e69e8c
2 changed files with 30 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/app/celery/test_scheduled_tasks.py
View File

@@ -1144,7 +1144,7 @@ def test_letter_not_raise_alert_if_ack_files_match_zip_list(mocker, notify_db):
@freeze_time('2018-01-11T23:00:00')
def test_letter_not_raise_alert_if_ack_files_not_match_zip_list(mocker, notify_db):
def test_letter_raise_alert_if_ack_files_not_match_zip_list(mocker, notify_db):
mock_file_list = mocker.patch("app.aws.s3.get_list_of_files_by_suffix", side_effect=mock_s3_get_list_diff)
mock_get_file = mocker.patch("app.aws.s3.get_s3_file",
return_value='NOTIFY.20180111175007.ZIP|20180111175733\n'
@@ -1157,9 +1157,18 @@ def test_letter_not_raise_alert_if_ack_files_not_match_zip_list(mocker, notify_d
assert e.value.message == str(set(['NOTIFY.20180111175009.ZIP', 'NOTIFY.20180111175010.ZIP']))
assert mock_file_list.call_count == 2
assert mock_get_file.call_count == 1
deskpro_message = "Letter ack does not contains all zip files sent. " \
"Missing ack for zip files: {}, " \
"pdf bucket: {}, subfolder: {}, " \
"ack bucket: {}".format(str(set(['NOTIFY.20180111175009.ZIP', 'NOTIFY.20180111175010.ZIP'])),
current_app.config['LETTERS_PDF_BUCKET_NAME'],
datetime.utcnow().strftime('%Y-%m-%d') + '/zips_sent',
current_app.config['DVLA_RESPONSE_BUCKET_NAME'])
mock_deskpro.assert_called_once_with(
subject="Letter acknowledge error",
message="Letter acknowledgement file do not contains all zip files sent: 2018-01-11",
message=deskpro_message,
ticket_type='alert'
)