Merge pull request #2359 from alphagov/remove-edit-folder-permission

Last commit to remove edit_folders.

app/models.py

@@ -270,7 +270,6 @@ EMAIL_AUTH = 'email_auth'
 LETTERS_AS_PDF = 'letters_as_pdf'
 PRECOMPILED_LETTER = 'precompiled_letter'
 UPLOAD_DOCUMENT = 'upload_document'
-EDIT_FOLDERS = 'edit_folders'
 
 SERVICE_PERMISSION_TYPES = [
     EMAIL_TYPE,
@@ -283,7 +282,6 @@ SERVICE_PERMISSION_TYPES = [
     LETTERS_AS_PDF,
     PRECOMPILED_LETTER,
     UPLOAD_DOCUMENT,
-    EDIT_FOLDERS,
 ]
 
 

migrations/versions/0263_remove_edit_folders_2.py

@@ -0,0 +1,23 @@
+"""
+
+Revision ID: 0263_remove_edit_folders_2
+Revises: 0262_remove_edit_folders
+Create Date: 2019-02-15 14:38:13.823432
+
+"""
+from alembic import op
+import sqlalchemy as sa
+
+
+revision = '0263_remove_edit_folders_2'
+down_revision = '0262_remove_edit_folders'
+
+
+def upgrade():
+    # run this again in case it got added between the 2 deploys
+    op.execute("DELETE from service_permissions where permission = 'edit_folders'")
+    op.execute("DELETE from service_permission_types where name = 'edit_folders'")
+
+
+def downgrade():
+    op.execute("INSERT INTO service_permission_types values('edit_folders')")