mirror of
https://github.com/GSA/notifications-api.git
synced 2025-12-20 23:41:17 -05:00
Stop populating job-statistics table when creating a job
This commit is contained in:
@@ -15,7 +15,6 @@ from app import db
|
||||
from app.dao import days_ago
|
||||
from app.models import (
|
||||
Job,
|
||||
JobStatistics,
|
||||
JOB_STATUS_PENDING,
|
||||
JOB_STATUS_SCHEDULED,
|
||||
LETTER_TYPE,
|
||||
@@ -109,11 +108,6 @@ def dao_get_future_scheduled_job_by_id_and_service_id(job_id, service_id):
|
||||
def dao_create_job(job):
|
||||
if not job.id:
|
||||
job.id = uuid.uuid4()
|
||||
job_stats = JobStatistics(
|
||||
job_id=job.id,
|
||||
updated_at=datetime.utcnow()
|
||||
)
|
||||
db.session.add(job_stats)
|
||||
db.session.add(job)
|
||||
db.session.commit()
|
||||
|
||||
|
||||
@@ -17,7 +17,7 @@ from app.dao.jobs_dao import (
|
||||
dao_get_jobs_older_than_limited_by,
|
||||
dao_get_letter_job_ids_by_status)
|
||||
from app.models import (
|
||||
Job, JobStatistics,
|
||||
Job,
|
||||
EMAIL_TYPE, SMS_TYPE, LETTER_TYPE,
|
||||
JOB_STATUS_READY_TO_SEND, JOB_STATUS_SENT_TO_DVLA, JOB_STATUS_FINISHED, JOB_STATUS_PENDING
|
||||
)
|
||||
@@ -142,23 +142,10 @@ def test_create_job(sample_template):
|
||||
dao_create_job(job)
|
||||
|
||||
assert Job.query.count() == 1
|
||||
assert JobStatistics.query.count() == 1
|
||||
job_from_db = Job.query.get(job_id)
|
||||
assert job == job_from_db
|
||||
assert job_from_db.notifications_delivered == 0
|
||||
assert job_from_db.notifications_failed == 0
|
||||
job_stats_from_db = JobStatistics.query.filter_by(job_id=job_id).all()
|
||||
assert len(job_stats_from_db) == 1
|
||||
assert job_stats_from_db[0].sms_sent == 0
|
||||
assert job_stats_from_db[0].emails_sent == 0
|
||||
assert job_stats_from_db[0].letters_sent == 0
|
||||
|
||||
assert job_stats_from_db[0].sms_failed == 0
|
||||
assert job_stats_from_db[0].emails_failed == 0
|
||||
assert job_stats_from_db[0].letters_failed == 0
|
||||
|
||||
assert job_stats_from_db[0].sms_delivered == 0
|
||||
assert job_stats_from_db[0].emails_delivered == 0
|
||||
|
||||
|
||||
def test_get_job_by_id(sample_job):
|
||||
|
||||
Reference in New Issue
Block a user