darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-20 07:21:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2290 from alphagov/its_not_a_failure_to_cancel

Browse Source 
Cancelled notifications don't show as failures in statistics
This commit is contained in:
Pea (Malgorzata Tyczynska)
2019-01-10 15:09:30 +00:00
committed by GitHub
parent 1719f31909 e179e1e4a4
commit c5e5c86982
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/service/statistics.py
View File

@@ -89,7 +89,7 @@ def _update_statuses_from_row(update_dict, row):
update_dict['delivered'] += row.count
elif row.status in (
'failed', 'technical-failure', 'temporary-failure',
'permanent-failure', 'validation-failed', 'virus-scan-failed', 'cancelled'):
'permanent-failure', 'validation-failed', 'virus-scan-failed'):
update_dict['failed'] += row.count

2
tests/app/service/test_statistics.py
View File

@@ -39,7 +39,7 @@ NewStatsRow = collections.namedtuple('row', ('notification_type', 'status', 'key
StatsRow('letter', 'virus-scan-failed', 1),
StatsRow('letter', 'permanent-failure', 1),
StatsRow('letter', 'cancelled', 1),
], [4, 0, 4], [0, 0, 0], [4, 0, 4]),
], [4, 0, 4], [0, 0, 0], [4, 0, 3]),
'convert_sent_to_delivered': ([
StatsRow('sms', 'sending', 1),
StatsRow('sms', 'delivered', 1),