darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-30 14:31:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

Trim down tests for DAO timeout function a bit

Browse Source 
The first test is enough to cover that "created" and "delivered"
notifications aren't affected by this function.
This commit is contained in:
Ben Thorner
2021-12-13 17:17:41 +00:00
parent 87cd40d00a
commit c1f0c24d82
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -682,34 +682,26 @@ def test_dao_timeout_notifications(sample_template):
def test_dao_timeout_notifications_only_updates_for_older_notifications(sample_template):
with freeze_time(datetime.utcnow() + timedelta(minutes=10)):
created = create_notification(sample_template, status='created')
sending = create_notification(sample_template, status='sending')
pending = create_notification(sample_template, status='pending')
delivered = create_notification(sample_template, status='delivered')
temporary_failure_notifications = dao_timeout_notifications(datetime.utcnow())
assert len(temporary_failure_notifications) == 0
assert Notification.query.get(created.id).status == 'created'
assert Notification.query.get(sending.id).status == 'sending'
assert Notification.query.get(pending.id).status == 'pending'
assert Notification.query.get(delivered.id).status == 'delivered'
def test_dao_timeout_notifications_doesnt_affect_letters(sample_letter_template):
with freeze_time(datetime.utcnow() - timedelta(minutes=2)):
created = create_notification(sample_letter_template, status='created')
sending = create_notification(sample_letter_template, status='sending')
pending = create_notification(sample_letter_template, status='pending')
delivered = create_notification(sample_letter_template, status='delivered')
temporary_failure_notifications = dao_timeout_notifications(datetime.utcnow())
assert len(temporary_failure_notifications) == 0
assert Notification.query.get(created.id).status == 'created'
assert Notification.query.get(sending.id).status == 'sending'
assert Notification.query.get(pending.id).status == 'pending'
assert Notification.query.get(delivered.id).status == 'delivered'
def test_should_return_notifications_excluding_jobs_by_default(sample_template, sample_job, sample_api_key):