darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-24 09:21:39 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #650 from alphagov/add-statistics-to-job

Browse Source 
Return empty stats list for job creation
This commit is contained in:
minglis
2016-08-31 16:25:25 +01:00
committed by GitHub
parent 6405cb74c7 57267a36f2
commit c09fa34edf
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/job/rest.py
View File

@@ -129,4 +129,7 @@ def create_job(service_id):
if job.job_status == JOB_STATUS_PENDING:
process_job.apply_async([str(job.id)], queue="process-job")
return jsonify(data=job_schema.dump(job).data), 201
job_json = job_schema.dump(job).data
job_json['statistics'] = []
return jsonify(data=job_json), 201

2
tests/app/job/test_rest.py
View File

@@ -140,6 +140,7 @@ def test_create_unscheduled_job(notify_api, sample_template, mocker, fake_uuid):
assert resp_json['data']['id'] == fake_uuid
assert resp_json['data']['status'] == 'pending'
assert resp_json['data']['statistics'] == []
assert not resp_json['data']['scheduled_for']
assert resp_json['data']['job_status'] == 'pending'
assert resp_json['data']['template'] == str(sample_template.id)
@@ -176,6 +177,7 @@ def test_create_scheduled_job(notify_api, sample_template, mocker, fake_uuid):
resp_json = json.loads(response.get_data(as_text=True))
assert resp_json['data']['id'] == fake_uuid
assert resp_json['data']['statistics'] == []
assert resp_json['data']['status'] == 'pending'
assert resp_json['data']['scheduled_for'] == datetime(2016, 1, 2, 11, 59, 0,
tzinfo=pytz.UTC).isoformat()