The logs kept reporting a data error from the redis client. This would happen any time we set the cache with empty cache values.

Added a check for values before setting the cache
This commit is contained in:
Rebecca Law
2017-08-22 14:59:50 +01:00
parent 66d1c3ca03
commit bf6e671e96

View File

@@ -76,7 +76,10 @@ def get_template_statistics_for_7_days(limit_days, service_id):
if not template_stats_by_id:
stats = dao_get_template_usage(service_id, limit_days=limit_days)
cache_values = dict([(x.template_id, x.count) for x in stats])
redis_store.set_hash_and_expire(cache_key, cache_values, current_app.config.get('EXPIRE_CACHE_IN_SECONDS', 600))
if cache_values:
redis_store.set_hash_and_expire(cache_key,
cache_values,
current_app.config.get('EXPIRE_CACHE_IN_SECONDS', 600))
else:
stats = dao_get_templates_for_cache(template_stats_by_id.items())
return stats