From bf6e671e96d4aec0a58334926681482bd9e77135 Mon Sep 17 00:00:00 2001 From: Rebecca Law Date: Tue, 22 Aug 2017 14:59:50 +0100 Subject: [PATCH] The logs kept reporting a data error from the redis client. This would happen any time we set the cache with empty cache values. Added a check for values before setting the cache --- app/template_statistics/rest.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/template_statistics/rest.py b/app/template_statistics/rest.py index 78ae711e4..67b6e72d1 100644 --- a/app/template_statistics/rest.py +++ b/app/template_statistics/rest.py @@ -76,7 +76,10 @@ def get_template_statistics_for_7_days(limit_days, service_id): if not template_stats_by_id: stats = dao_get_template_usage(service_id, limit_days=limit_days) cache_values = dict([(x.template_id, x.count) for x in stats]) - redis_store.set_hash_and_expire(cache_key, cache_values, current_app.config.get('EXPIRE_CACHE_IN_SECONDS', 600)) + if cache_values: + redis_store.set_hash_and_expire(cache_key, + cache_values, + current_app.config.get('EXPIRE_CACHE_IN_SECONDS', 600)) else: stats = dao_get_templates_for_cache(template_stats_by_id.items()) return stats