darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 23:55:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #788 from GSA/notify-api-784

Browse Source 
notify-api-784 remove simulated numbers
This commit is contained in:
Carlo Costino
2024-02-02 14:02:54 -05:00
committed by GitHub
parent f1b1c01f97 3e6ea3aa2c
commit b3a30f291e
5 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/aws/s3.py
View File

@@ -118,7 +118,10 @@ def extract_phones(job):
current_app.logger.info(f"LENGTH OF ROW IS {len(row)}")
if phone_index >= len(row):
phones[job_row] = "Error: can't retrieve phone number"
current_app.logger.error("Corrupt csv file")
current_app.logger.error(
"Corrupt csv file, missing columns or possibly a byte order mark in the file"
)
else:
my_phone = row[phone_index]
my_phone = re.sub(r"[\+\s\(\)\-\.]*", "", my_phone)

3
app/config.py
View File

@@ -283,7 +283,8 @@ class Config(object):
"simulate-delivered-2@notifications.service.gov.uk",
"simulate-delivered-3@notifications.service.gov.uk",
)
SIMULATED_SMS_NUMBERS = ("+12028675000", "+12028675111", "+12028675222")
# 7755 is success, 7167 is failure
SIMULATED_SMS_NUMBERS = ("+14254147755", "+14254147167")
FREE_SMS_TIER_FRAGMENT_COUNT = 250000

9
tests/app/notifications/test_process_notification.py
View File

@@ -254,11 +254,8 @@ def test_send_notification_to_queue_throws_exception_deletes_notification(
@pytest.mark.parametrize(
"to_address, notification_type, expected",
[
("+12028675000", "sms", True),
("+12028675111", "sms", True),
("+12028675222", "sms", True),
("2028675000", "sms", True),
("2028675111", "sms", True),
("+14254147755", "sms", True),
("+14254147167", "sms", True),
("simulate-delivered@notifications.service.gov.uk", "email", True),
("simulate-delivered-2@notifications.service.gov.uk", "email", True),
("simulate-delivered-3@notifications.service.gov.uk", "email", True),
@@ -275,7 +272,7 @@ def test_simulated_recipient(notify_api, to_address, notification_type, expected
'simulate-delivered-2@notifications.service.gov.uk',
'simulate-delivered-2@notifications.service.gov.uk'
)
SIMULATED_SMS_NUMBERS = ('+12028675000', '+12028675111', '+12028675222')
SIMULATED_SMS_NUMBERS = ("+14254147755", "+14254147167")
"""
formatted_address = None

2
tests/app/service/send_notification/test_send_notification.py
View File

@@ -881,7 +881,7 @@ def test_should_not_persist_notification_or_send_email_if_simulated_email(
assert Notification.query.count() == 0
@pytest.mark.parametrize("to_sms", ["2028675000", "2028675111", "+12028675222"])
@pytest.mark.parametrize("to_sms", ["+14254147755", "+14254147167"])
def test_should_not_persist_notification_or_send_sms_if_simulated_number(
client, to_sms, sample_template, mocker
):

5
tests/app/v2/notifications/test_post_notifications.py
View File

@@ -532,9 +532,8 @@ def test_post_email_notification_returns_201(
("simulate-delivered@notifications.service.gov.uk", EMAIL_TYPE),
("simulate-delivered-2@notifications.service.gov.uk", EMAIL_TYPE),
("simulate-delivered-3@notifications.service.gov.uk", EMAIL_TYPE),
("2028675000", "sms"),
("2028675111", "sms"),
("2028675222", "sms"),
("+14254147167", "sms"),
("+14254147755", "sms"),
],
)
def test_should_not_persist_or_send_notification_if_simulated_recipient(