darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-28 03:11:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add checks to ensure simulated notifications are not persisted to database

Browse Source
This commit is contained in:
Imdad Ahad
2016-09-14 11:12:57 +01:00
parent d4b0f68a69
commit af8cfbe78c
1 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/app/notifications/rest/test_send_notification.py
View File

@@ -948,7 +948,13 @@ def test_should_delete_sms_notification_and_return_error_if_sqs_fails(notify_api
'simulate-permanent-failure@notifications.service.gov.uk',
'simulate-temporary-failure@notifications.service.gov.uk'
])
def test_should_not_send_email_if_simulated_email_address(client, to_email, sample_email_template, mocker):
def test_should_not_persist_notification_or_send_email_if_simulated_email(
client,
to_email,
sample_email_template,
fake_uuid,
mocker):
mocker.patch('app.notifications.rest.create_uuid', return_value=fake_uuid)
apply_async = mocker.patch('app.celery.provider_tasks.send_email_to_provider.apply_async')
data = {
@@ -964,6 +970,7 @@ def test_should_not_send_email_if_simulated_email_address(client, to_email, samp
headers=[('Content-Type', 'application/json'), auth_header])
assert response.status_code == 201
assert not notifications_dao.get_notification_by_id(fake_uuid)
apply_async.assert_not_called()
@@ -972,7 +979,13 @@ def test_should_not_send_email_if_simulated_email_address(client, to_email, samp
'07700 900111',
'07700 900222'
])
def test_should_not_send_sms_if_simulated_sms_number(client, to_sms, sample_template, mocker):
def test_should_not_persist_notification_or_send_sms_if_simulated_number(
client,
to_sms,
sample_template,
fake_uuid,
mocker):
mocker.patch('app.notifications.rest.create_uuid', return_value=fake_uuid)
apply_async = mocker.patch('app.celery.provider_tasks.send_sms_to_provider.apply_async')
data = {
@@ -988,4 +1001,5 @@ def test_should_not_send_sms_if_simulated_sms_number(client, to_sms, sample_temp
headers=[('Content-Type', 'application/json'), auth_header])
assert response.status_code == 201
assert not notifications_dao.get_notification_by_id(fake_uuid)
apply_async.assert_not_called()