darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-04-26 12:20:14 -04:00
Code Issues Packages Projects Releases Wiki Activity

don't use global s3 client

Browse Source
This commit is contained in:
Kenneth Kehl
2025-06-27 13:01:30 -07:00
parent 123a379f73
commit ac7ba7a95d
1 changed files with 17 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
tests/app/aws/test_s3.py
View File

@@ -615,34 +615,23 @@ def test_get_s3_client_default_credentials():
mock_session.return_value.client.assert_called_once_with(
"s3",
config=ANY,
aws_access_id=None,
aws_secret_access_key=None, # pragma: allowlist secret
region_name="us-north-1",
)
# def test_get_s3_client_invalid_credentials():
# with patch.dict(
# os.environ,
# {
# "AWS_ACCESS_KEY_ID": "invalid-key",
# "AWS_SECRET_ACCESS_KEY": "invalid-secret", # pragma: allowlist secret
# "AWS_DEFAULT_REGION": "us-north-1",
# },
# ):
# with patch("boto3.client", side_effect = (
# botocore.exceptions.ClientError(
# {
# "Error": {
# "Code": "InvalidClientTokenId",
# "Message": "Invalid credentials",
# }
# },
# "GetObject",
# )
# )
# try:
# get_s3_client()
# assert 1 == 0
# except botocore.exceptions.ClientError as e:
# assert e.response["Error"]["Code"] == "InvalidClientTokenId"
def test_get_s3_client_invalid_credentials():
with patch("app.aws.s3.Session") as mock_session:
mock_session.return_value.client.side_effect = botocore.exceptions.ClientError(
{
"Error": {
"Code": "InvalidClientTokenId",
"Message": "Invalid credentials",
}
},
"HeadBucket",
)
try:
get_s3_client()
assert 1 == 0
except botocore.exceptions.ClientError as e:
assert e.response["Error"]["Code"] == "InvalidClientTokenId"