darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 23:55:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

put more log messages to view what env returns

Browse Source
This commit is contained in:
venusbb
2017-07-12 13:49:20 +01:00
parent 19481cda02
commit a5cf8ff60f
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/authentication/auth.py
View File

@@ -52,7 +52,8 @@ def restrict_ip_sms():
ip_list = ip_route.split(',')
if len(ip_list) >= 3:
ip = ip_list[len(ip_list) - 3]
current_app.logger.info("Inbound sms ip route list {}".format(ip_route))
current_app.logger.info("Inbound sms ip route list {} OS environ{}"
.format(ip_route, current_app.config.get('SMS_INBOUND_WHITELIST')))
if ip in current_app.config.get('SMS_INBOUND_WHITELIST'):
current_app.logger.info("Inbound sms ip addresses {} passed ".format(ip))

4
tests/app/authentication/test_authentication.py
View File

@@ -351,7 +351,7 @@ def test_reject_invalid_ips(restrict_ip_sms_app):
assert exc_info.value.short_message == 'Unknown source IP address from the SMS provider'
@pytest.mark.xfail(reason='Currently not blocking invalid IPs', strict=True)
@pytest.mark.xfail(reason='Currently not blocking invalid senders', strict=True)
def test_illegitimate_ips(restrict_ip_sms_app):
with pytest.raises(AuthError) as exc_info:
restrict_ip_sms_app.get(
@@ -361,4 +361,4 @@ def test_illegitimate_ips(restrict_ip_sms_app):
]
)
assert exc_info.value.short_message == 'Unknown source IP address from the SMS provider'
assert exc_info.value.short_message == 'Unknown IP route not from known SMS provider'