darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Require "sender" argument to send_sms method

Browse Source 
In response to [^1].

[^1]: https://github.com/alphagov/notifications-api/pull/3493#discussion_r836616675
This commit is contained in:
Ben Thorner
2022-03-29 12:37:42 +01:00
parent 015152bab2
commit a2e1d03009
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/clients/sms/__init__.py
View File

@@ -38,7 +38,7 @@ class SmsClient(Client):
self.statsd_client.incr(f"clients.{self.name}.error") self.statsd_client.incr(f"clients.{self.name}.error")
self.current_app.logger.warning(log_message) self.current_app.logger.warning(log_message)
def send_sms(self, to, content, reference, international, sender=None): def send_sms(self, to, content, reference, international, sender):
start_time = monotonic() start_time = monotonic()
sender = self.from_number if sender is None else sender sender = self.from_number if sender is None else sender

2
tests/app/clients/test_sms.py
View File

@@ -24,6 +24,7 @@ def test_send_sms(fake_client, mocker):
content='content', content='content',
reference='reference', reference='reference',
international=False, international=False,
sender=None,
) )
mock_send.assert_called_with( mock_send.assert_called_with(
@@ -42,6 +43,7 @@ def test_send_sms_error(fake_client, mocker):
content='content', content='content',
reference='reference', reference='reference',
international=False, international=False,
sender=None,
) )