From a2e1d030095bcb7bb5829a37424e1e5fb8937dc3 Mon Sep 17 00:00:00 2001 From: Ben Thorner Date: Tue, 29 Mar 2022 12:37:42 +0100 Subject: [PATCH] Require "sender" argument to send_sms method In response to [^1]. [^1]: https://github.com/alphagov/notifications-api/pull/3493#discussion_r836616675 --- app/clients/sms/__init__.py | 2 +- tests/app/clients/test_sms.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/clients/sms/__init__.py b/app/clients/sms/__init__.py index 6a10374f2..3a2ba1367 100644 --- a/app/clients/sms/__init__.py +++ b/app/clients/sms/__init__.py @@ -38,7 +38,7 @@ class SmsClient(Client): self.statsd_client.incr(f"clients.{self.name}.error") self.current_app.logger.warning(log_message) - def send_sms(self, to, content, reference, international, sender=None): + def send_sms(self, to, content, reference, international, sender): start_time = monotonic() sender = self.from_number if sender is None else sender diff --git a/tests/app/clients/test_sms.py b/tests/app/clients/test_sms.py index de0b06441..b61777a35 100644 --- a/tests/app/clients/test_sms.py +++ b/tests/app/clients/test_sms.py @@ -24,6 +24,7 @@ def test_send_sms(fake_client, mocker): content='content', reference='reference', international=False, + sender=None, ) mock_send.assert_called_with( @@ -42,6 +43,7 @@ def test_send_sms_error(fake_client, mocker): content='content', reference='reference', international=False, + sender=None, )