darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-09 05:13:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix tests

Browse Source 
Specifically, no longer test for a p1 zendesk when sending an alert
and drop misleading "p1" from test name when cancelling an alert.

We're no longer creating a P1 from the code, but we _do_ create a
zendesk ticket when sending out an alert.

When cancelling, what we want to test is that we don't create a second
ticket when the alert is cancelled.
This commit is contained in:
sakisv
2021-09-10 10:03:09 +03:00
parent 65c21f694c
commit 9faa3d34e1
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/app/celery/test_broadcast_message_tasks.py
View File

@@ -99,7 +99,7 @@ def test_send_broadcast_event_does_nothing_if_provider_set_on_service_isnt_enabl
({'names': ['England', 'Scotland']}, ['England', 'Scotland']), ({'names': ['England', 'Scotland']}, ['England', 'Scotland']),
({}, []) ({}, [])
]) ])
def test_send_broadcast_event_creates_zendesk_p1( def test_send_broadcast_event_creates_zendesk(
area_data, area_data,
expected_message, expected_message,
mocker, mocker,
@@ -122,7 +122,6 @@ def test_send_broadcast_event_creates_zendesk_p1(
assert mock_create_ticket.call_count == 1 assert mock_create_ticket.call_count == 1
zendesk_args = mock_create_ticket.call_args[1] zendesk_args = mock_create_ticket.call_args[1]
assert zendesk_args['p1'] is True
assert zendesk_args['ticket_type'] == 'incident' assert zendesk_args['ticket_type'] == 'incident'
assert str(broadcast_message.id) in zendesk_args['message'] assert str(broadcast_message.id) in zendesk_args['message']
@@ -132,7 +131,7 @@ def test_send_broadcast_event_creates_zendesk_p1(
assert "Dear Sir/Madam" in zendesk_args['message'] assert "Dear Sir/Madam" in zendesk_args['message']
def test_send_broadcast_event_doesnt_p1_when_cancelling(mocker, notify_api, sample_broadcast_service): def test_send_broadcast_event_doesnt_create_zendesk_when_cancelling(mocker, notify_api, sample_broadcast_service):
template = create_template(sample_broadcast_service, BROADCAST_TYPE) template = create_template(sample_broadcast_service, BROADCAST_TYPE)
broadcast_message = create_broadcast_message( broadcast_message = create_broadcast_message(
template, template,