From 9faa3d34e14f10b059564c103f7b04967c156770 Mon Sep 17 00:00:00 2001 From: sakisv Date: Fri, 10 Sep 2021 10:03:09 +0300 Subject: [PATCH] Fix tests Specifically, no longer test for a p1 zendesk when sending an alert and drop misleading "p1" from test name when cancelling an alert. We're no longer creating a P1 from the code, but we _do_ create a zendesk ticket when sending out an alert. When cancelling, what we want to test is that we don't create a second ticket when the alert is cancelled. --- tests/app/celery/test_broadcast_message_tasks.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/app/celery/test_broadcast_message_tasks.py b/tests/app/celery/test_broadcast_message_tasks.py index 5411419a5..7d9a32289 100644 --- a/tests/app/celery/test_broadcast_message_tasks.py +++ b/tests/app/celery/test_broadcast_message_tasks.py @@ -99,7 +99,7 @@ def test_send_broadcast_event_does_nothing_if_provider_set_on_service_isnt_enabl ({'names': ['England', 'Scotland']}, ['England', 'Scotland']), ({}, []) ]) -def test_send_broadcast_event_creates_zendesk_p1( +def test_send_broadcast_event_creates_zendesk( area_data, expected_message, mocker, @@ -122,7 +122,6 @@ def test_send_broadcast_event_creates_zendesk_p1( assert mock_create_ticket.call_count == 1 zendesk_args = mock_create_ticket.call_args[1] - assert zendesk_args['p1'] is True assert zendesk_args['ticket_type'] == 'incident' assert str(broadcast_message.id) in zendesk_args['message'] @@ -132,7 +131,7 @@ def test_send_broadcast_event_creates_zendesk_p1( assert "Dear Sir/Madam" in zendesk_args['message'] -def test_send_broadcast_event_doesnt_p1_when_cancelling(mocker, notify_api, sample_broadcast_service): +def test_send_broadcast_event_doesnt_create_zendesk_when_cancelling(mocker, notify_api, sample_broadcast_service): template = create_template(sample_broadcast_service, BROADCAST_TYPE) broadcast_message = create_broadcast_message( template,