darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-24 01:11:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove exception thrown when getting default sender.

Browse Source 
Having more than one default is checked on insert and update.
This commit is contained in:
Rebecca Law
2017-10-04 14:51:02 +01:00
parent cefb74c732
commit 9d507466ef
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/models.py
View File

@@ -257,23 +257,15 @@ class Service(db.Model, Versioned):
def get_default_sms_sender(self):
default_sms_sender = [x for x in self.service_sms_senders if x.is_default]
if len(default_sms_sender) > 1:
raise Exception("There should only ever be one default")
return default_sms_sender[0].sms_sender
def get_default_reply_to_email_address(self):
default_reply_to = [x for x in self.reply_to_email_addresses if x.is_default]
if len(default_reply_to) > 1:
raise Exception("There should only ever be one default")
else:
return default_reply_to[0].email_address if default_reply_to else None
return default_reply_to[0].email_address if default_reply_to else None
def get_default_letter_contact(self):
default_letter_contact = [x for x in self.letter_contacts if x.is_default]
if len(default_letter_contact) > 1:
raise Exception("There should only ever be one default")
else:
return default_letter_contact[0].contact_block if default_letter_contact else None
return default_letter_contact[0].contact_block if default_letter_contact else None
class InboundNumber(db.Model):