darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 08:51:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update error message after discussion with Karl

Browse Source
This commit is contained in:
Pea Tyczynska
2020-02-25 17:10:22 +00:00
parent ed1bc8d806
commit 9a12d0e80e
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/notifications/validators.py
View File

@@ -91,7 +91,9 @@ def check_service_has_permission(notify_type, permissions):
def check_if_service_can_send_files_by_email(service_contact_link): def check_if_service_can_send_files_by_email(service_contact_link):
if not service_contact_link: if not service_contact_link:
raise BadRequestError(message="Go to Service Settings to turn on sending files by email") raise BadRequestError(
message="Send files by email is not set up yet. Go to your settings page to manage send files by email"
)
def check_service_can_schedule_notification(permissions, scheduled_for): def check_service_can_schedule_notification(permissions, scheduled_for):

4
tests/app/notifications/test_validators.py
View File

@@ -534,8 +534,10 @@ def test_check_reply_to_letter_type(sample_service):
def test_check_if_service_can_send_files_by_email_raises_if_no_contact_link_set(sample_service): def test_check_if_service_can_send_files_by_email_raises_if_no_contact_link_set(sample_service):
with pytest.raises(BadRequestError) as e: with pytest.raises(BadRequestError) as e:
check_if_service_can_send_files_by_email(sample_service.contact_link) check_if_service_can_send_files_by_email(sample_service.contact_link)
expected_message = "Send files by email is not set up yet. Go to your settings page to manage send files by email"
assert e.value.status_code == 400 assert e.value.status_code == 400
assert e.value.message == "Go to Service Settings to turn on sending files by email" assert e.value.message == expected_message
def test_check_if_service_can_send_files_by_email_passes_if_contact_link_set(sample_service): def test_check_if_service_can_send_files_by_email_passes_if_contact_link_set(sample_service):