diff --git a/app/notifications/validators.py b/app/notifications/validators.py index 1ef0a49a4..5e5bf8ce0 100644 --- a/app/notifications/validators.py +++ b/app/notifications/validators.py @@ -91,7 +91,9 @@ def check_service_has_permission(notify_type, permissions): def check_if_service_can_send_files_by_email(service_contact_link): if not service_contact_link: - raise BadRequestError(message="Go to Service Settings to turn on sending files by email") + raise BadRequestError( + message="Send files by email is not set up yet. Go to your settings page to manage send files by email" + ) def check_service_can_schedule_notification(permissions, scheduled_for): diff --git a/tests/app/notifications/test_validators.py b/tests/app/notifications/test_validators.py index 5e6342c38..b6405f0e9 100644 --- a/tests/app/notifications/test_validators.py +++ b/tests/app/notifications/test_validators.py @@ -534,8 +534,10 @@ def test_check_reply_to_letter_type(sample_service): def test_check_if_service_can_send_files_by_email_raises_if_no_contact_link_set(sample_service): with pytest.raises(BadRequestError) as e: check_if_service_can_send_files_by_email(sample_service.contact_link) + + expected_message = "Send files by email is not set up yet. Go to your settings page to manage send files by email" assert e.value.status_code == 400 - assert e.value.message == "Go to Service Settings to turn on sending files by email" + assert e.value.message == expected_message def test_check_if_service_can_send_files_by_email_passes_if_contact_link_set(sample_service):