darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-20 22:39:43 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3496 from alphagov/fix-send-sms-log

Browse Source 
Fix log for sending SMS to be generic per client
This commit is contained in:
Ben Thorner
2022-04-05 11:49:59 +01:00
committed by GitHub
parent 7631e9abc9 4a40b169a2
commit 9902ddfc22
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/clients/sms/__init__.py
View File

@@ -59,7 +59,7 @@ class SmsClient(Client):
finally: finally:
elapsed_time = monotonic() - start_time elapsed_time = monotonic() - start_time
self.statsd_client.timing(f"clients.{self.name}.request-time", elapsed_time) self.statsd_client.timing(f"clients.{self.name}.request-time", elapsed_time)
self.current_app.logger.info("Reach request for {} finished in {}".format(reference, elapsed_time)) self.current_app.logger.info(f"{self.name} request for {reference} finished in {elapsed_time}")
return response return response

1
tests/app/dao/test_fact_notification_status_dao.py
View File

@@ -611,6 +611,7 @@ def test_get_total_notifications_for_date_range(sample_service):
assert results[0] == ("2021-03-01", 15, 20, 3) assert results[0] == ("2021-03-01", 15, 20, 3)
@freeze_time('2022-03-31T18:00:00')
@pytest.mark.parametrize('created_at_utc,process_day,expected_count', [ @pytest.mark.parametrize('created_at_utc,process_day,expected_count', [
# Clocks change on the 27th of March 2022, so the query needs to look at the # Clocks change on the 27th of March 2022, so the query needs to look at the
# time range 00:00 - 23:00 (UTC) thereafter. # time range 00:00 - 23:00 (UTC) thereafter.