Merge pull request #3496 from alphagov/fix-send-sms-log

Fix log for sending SMS to be generic per client

app/clients/sms/__init__.py

@@ -59,7 +59,7 @@ class SmsClient(Client):
         finally:
             elapsed_time = monotonic() - start_time
             self.statsd_client.timing(f"clients.{self.name}.request-time", elapsed_time)
-            self.current_app.logger.info("Reach request for {} finished in {}".format(reference, elapsed_time))
+            self.current_app.logger.info(f"{self.name} request for {reference} finished in {elapsed_time}")
 
         return response
 

tests/app/dao/test_fact_notification_status_dao.py

@@ -611,6 +611,7 @@ def test_get_total_notifications_for_date_range(sample_service):
     assert results[0] == ("2021-03-01", 15, 20, 3)
 
 
+@freeze_time('2022-03-31T18:00:00')
 @pytest.mark.parametrize('created_at_utc,process_day,expected_count', [
     # Clocks change on the 27th of March 2022, so the query needs to look at the
     # time range 00:00 - 23:00 (UTC) thereafter.