darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-24 16:23:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor to use .count() method instead of mocking fake UUID

Browse Source
This commit is contained in:
Imdad Ahad
2016-09-14 13:07:57 +01:00
parent af8cfbe78c
commit 98ef340bc6
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/app/notifications/rest/test_send_notification.py
View File

@@ -952,9 +952,7 @@ def test_should_not_persist_notification_or_send_email_if_simulated_email(
client, client,
to_email, to_email,
sample_email_template, sample_email_template,
fake_uuid,
mocker): mocker):
mocker.patch('app.notifications.rest.create_uuid', return_value=fake_uuid)
apply_async = mocker.patch('app.celery.provider_tasks.send_email_to_provider.apply_async') apply_async = mocker.patch('app.celery.provider_tasks.send_email_to_provider.apply_async')
data = { data = {
@@ -970,8 +968,8 @@ def test_should_not_persist_notification_or_send_email_if_simulated_email(
headers=[('Content-Type', 'application/json'), auth_header]) headers=[('Content-Type', 'application/json'), auth_header])
assert response.status_code == 201 assert response.status_code == 201
assert not notifications_dao.get_notification_by_id(fake_uuid)
apply_async.assert_not_called() apply_async.assert_not_called()
assert Notification.query.count() == 0
@pytest.mark.parametrize('to_sms', [ @pytest.mark.parametrize('to_sms', [
@@ -983,9 +981,7 @@ def test_should_not_persist_notification_or_send_sms_if_simulated_number(
client, client,
to_sms, to_sms,
sample_template, sample_template,
fake_uuid,
mocker): mocker):
mocker.patch('app.notifications.rest.create_uuid', return_value=fake_uuid)
apply_async = mocker.patch('app.celery.provider_tasks.send_sms_to_provider.apply_async') apply_async = mocker.patch('app.celery.provider_tasks.send_sms_to_provider.apply_async')
data = { data = {
@@ -1001,5 +997,5 @@ def test_should_not_persist_notification_or_send_sms_if_simulated_number(
headers=[('Content-Type', 'application/json'), auth_header]) headers=[('Content-Type', 'application/json'), auth_header])
assert response.status_code == 201 assert response.status_code == 201
assert not notifications_dao.get_notification_by_id(fake_uuid)
apply_async.assert_not_called() apply_async.assert_not_called()
assert Notification.query.count() == 0