Merge pull request #2639 from alphagov/remove-loadtesting-db-migration

remove loadtesting from the database

migrations/versions/0308_delete_loadtesting_provider.py

@@ -0,0 +1,39 @@
+"""
+Remove loadtesting provider
+
+Revision ID: 0308_delete_loadtesting_provider
+Revises: 0307_delete_dm_datetime
+Create Date: 2019-10-22 17:30
+
+"""
+import uuid
+from alembic import op
+from sqlalchemy.sql import text
+
+revision = '0308_delete_loadtesting_provider'
+down_revision = '0307_delete_dm_datetime'
+
+
+def upgrade():
+    conn = op.get_bind()
+    conn.execute("DELETE FROM provider_details WHERE identifier = 'loadtesting'")
+    conn.execute("DELETE FROM provider_details_history WHERE identifier = 'loadtesting'")
+
+
+def downgrade():
+    conn = op.get_bind()
+    conn.execute(
+        text("""
+        INSERT INTO
+        provider_details
+        (id, display_name, identifier, priority, notification_type, active, version, supports_international)
+        VALUES
+        (:uuid, 'Loadtesting', 'loadtesting', 100, 'sms', true, 1, false);
+        INSERT INTO
+        provider_details_history
+        (id, display_name, identifier, priority, notification_type, active, version, supports_international)
+        VALUES
+        (:uuid, 'Loadtesting', 'loadtesting', 100, 'sms', true, 1, false)
+        """),
+        uuid=uuid.uuid4()
+    )

tests/app/dao/test_provider_details_dao.py

@@ -38,7 +38,7 @@ def set_primary_sms_provider(identifier):
 
 def test_can_get_sms_non_international_providers(restore_provider_details):
     sms_providers = get_provider_details_by_notification_type('sms')
-    assert len(sms_providers) == 3
+    assert len(sms_providers) == 2
     assert all('sms' == prov.notification_type for prov in sms_providers)
 
 
@@ -307,7 +307,7 @@ def test_dao_get_provider_stats(notify_db_session):
 
     result = dao_get_provider_stats()
 
-    assert len(result) == 5
+    assert len(result) == 4
 
     assert result[0].identifier == 'ses'
     assert result[0].display_name == 'AWS SES'
@@ -326,9 +326,6 @@ def test_dao_get_provider_stats(notify_db_session):
     assert result[2].active is True
     assert result[2].current_month_billable_sms == 5
 
-    assert result[3].identifier == 'loadtesting'
+    assert result[3].identifier == 'dvla'
     assert result[3].current_month_billable_sms == 0
-
-    assert result[4].identifier == 'dvla'
-    assert result[4].current_month_billable_sms == 0
-    assert result[4].supports_international is False
+    assert result[3].supports_international is False

tests/app/provider_details/test_rest.py

@@ -15,13 +15,12 @@ def test_get_provider_details_in_type_and_identifier_order(client, notify_db):
     )
     assert response.status_code == 200
     json_resp = json.loads(response.get_data(as_text=True))['provider_details']
-    assert len(json_resp) == 5
+    assert len(json_resp) == 4
 
     assert json_resp[0]['identifier'] == 'ses'
     assert json_resp[1]['identifier'] == 'mmg'
     assert json_resp[2]['identifier'] == 'firetext'
-    assert json_resp[3]['identifier'] == 'loadtesting'
-    assert json_resp[4]['identifier'] == 'dvla'
+    assert json_resp[3]['identifier'] == 'dvla'
 
 
 def test_get_provider_details_by_id(client, notify_db):
@@ -55,7 +54,7 @@ def test_get_provider_contains_correct_fields(client, sample_service, sample_tem
         "active", "updated_at", "supports_international",
         "current_month_billable_sms"
     }
-    assert len(json_resp) == 5
+    assert len(json_resp) == 4
     assert allowed_keys == set(json_resp[0].keys())