darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-20 07:21:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

code review feedback

Browse Source
This commit is contained in:
Kenneth Kehl
2024-01-08 14:31:28 -08:00
parent a5f78224b2
commit 726e0b15fa
4 changed files with 19 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/aws/s3.py
View File

@@ -1,3 +1,5 @@
import re
import botocore
from boto3 import Session
from expiringdict import ExpiringDict
@@ -8,7 +10,7 @@ from app.clients import AWS_CLIENT_CONFIG
FILE_LOCATION_STRUCTURE = "service-{}-notify/{}.csv"
JOBS = ExpiringDict(max_len=100, max_age_seconds=3600)
JOBS = ExpiringDict(max_len=100, max_age_seconds=3600 * 4)
def get_s3_file(bucket_name, file_location, access_key, secret_key, region):
@@ -91,11 +93,7 @@ def get_phone_number_from_s3(service_id, job_id, job_row_number):
correct_row = correct_row.split(",")
my_phone = correct_row[phone_index]
my_phone = my_phone.replace("(", "")
my_phone = my_phone.replace(")", "")
my_phone = my_phone.replace("-", "")
my_phone = my_phone.replace(" ", "")
my_phone = my_phone.replace("+", "")
my_phone = re.sub(r"[\+\s\(\)\-\.]*", "", my_phone)
return my_phone