darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-04-21 09:49:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2698 from alphagov/alert-limit

Browse Source 
Up threshold for sms to telephone numbers
This commit is contained in:
David McDonald
2020-01-20 10:15:06 +00:00
committed by GitHub
parent 879ba1d5f0 3a0aece6a1
commit 65ce879825
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/celery/scheduled_tasks.py
View File

@@ -286,7 +286,7 @@ def check_for_services_with_high_failure_rates_or_sending_to_tv_numbers():
)
message += "service: {} failure rate: {},\n".format(service_dashboard, service.permanent_failure_rate)
elif services_sending_to_tv_numbers:
message += "{} service(s) have sent over 100 sms messages to tv numbers in last 24 hours:\n".format(
message += "{} service(s) have sent over 500 sms messages to tv numbers in last 24 hours:\n".format(
len(services_sending_to_tv_numbers)
)
for service in services_sending_to_tv_numbers:

2
app/dao/services_dao.py
View File

@@ -525,7 +525,7 @@ def dao_fetch_active_users_for_service(service_id):
return query.all()
def dao_find_services_sending_to_tv_numbers(start_date, end_date, threshold=100):
def dao_find_services_sending_to_tv_numbers(start_date, end_date, threshold=500):
return db.session.query(
Notification.service_id.label('service_id'),
func.count(Notification.id).label('notification_count')

2
tests/app/celery/test_scheduled_tasks.py
View File

@@ -526,7 +526,7 @@ MockServicesWithHighFailureRate = namedtuple(
[
[],
[MockServicesSendingToTVNumbers("123", 300)],
"1 service(s) have sent over 100 sms messages to tv numbers in last 24 hours:\n"
"1 service(s) have sent over 500 sms messages to tv numbers in last 24 hours:\n"
"service: {}/services/{} count of sms to tv numbers: 300,\n".format(
Config.ADMIN_BASE_URL, "123"
)